Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1006473002: Ignore public API checks if COMMIT=false is in the description (Closed)

Created:
5 years, 9 months ago by rmistry
Modified:
5 years, 9 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Ignore public API checks if COMMIT=false is in the description BUG=skia: NOTRY=true Committed: https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621 Committed: https://skia.googlesource.com/skia/+/f91b717a996553a4ed65b8bf805e56549cd6fde3

Patch Set 1 : Initial upload #

Patch Set 2 : Cleanup #

Patch Set 3 : Remove testing code #

Patch Set 4 : Cleanup #

Patch Set 5 : Remove test code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M PRESUBMIT.py View 1 2 4 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
rmistry
5 years, 9 months ago (2015-03-12 15:21:09 UTC) #3
borenet
LGTM
5 years, 9 months ago (2015-03-12 15:22:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006473002/60001
5 years, 9 months ago (2015-03-12 15:23:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006473002/80001
5 years, 9 months ago (2015-03-12 15:33:49 UTC) #9
commit-bot: I haz the power
This issue passed the CQ. To commit it, remove "COMMIT=false" from the description and try ...
5 years, 9 months ago (2015-03-12 15:42:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006473002/80001
5 years, 9 months ago (2015-03-12 15:43:13 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:80001) as https://skia.googlesource.com/skia/+/d1783aefcc0da86c5ff1d124c54704252d817621
5 years, 9 months ago (2015-03-12 15:43:27 UTC) #13
mtklein
A revert of this CL (patchset #4 id:80001) has been created in https://codereview.chromium.org/1005583002/ by mtklein@google.com. ...
5 years, 9 months ago (2015-03-12 16:33:29 UTC) #14
rmistry
On 2015/03/12 16:33:29, mtklein wrote: > A revert of this CL (patchset #4 id:80001) has ...
5 years, 9 months ago (2015-03-12 16:47:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006473002/100001
5 years, 9 months ago (2015-03-12 16:48:02 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 16:48:18 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:100001) as
https://skia.googlesource.com/skia/+/f91b717a996553a4ed65b8bf805e56549cd6fde3

Powered by Google App Engine
This is Rietveld 408576698