Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: PRESUBMIT.py

Issue 1006473002: Ignore public API checks if COMMIT=false is in the description (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Remove test code Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index d62249a6059ce5aea4c6c210fdd97bd285b3d1ca..ae5a2183162c81026e8e382e6792b75fe362cc8c 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -254,6 +254,11 @@ def _CheckLGTMsForPublicAPI(input_api, output_api):
# It is a revert CL, ignore the public api owners check.
return results
+ if re.search(r'^COMMIT=false$', issue_properties['description'], re.M):
+ # Ignore public api owners check for COMMIT=false CLs since they are not
+ # going to be committed.
+ return results
+
match = re.search(r'^TBR=(.*)$', issue_properties['description'], re.M)
if match:
tbr_entries = match.group(1).strip().split(',')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698