Issue 1006093002: Collapsed gl query functions with their ARB/EXT variants.

Issue 1006093002: Collapsed gl query functions with their ARB/EXT variants. (Closed)

Created:
5 years, 9 months ago by David Yen

Modified:
5 years, 9 months ago

Reviewers:
no sievers

CC:
chromium-reviews, piman+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Collapsed gl query functions with their ARB/EXT variants. R=sievers@chromium.org BUG=466725 TEST=trybots Committed: https://crrev.com/d09e8c398fffce740e3b8b62d4cef3d7341a3361 Cr-Commit-Position: refs/heads/master@{#320814}

Patch Set 1 #

Patch Set 2 : Also collapsed glEndQuery #

Patch Set 3 : Fixed unittests, glBeginQuery #

Patch Set 4 : Fixed gles2 decoder tests #

Total comments: 4

Patch Set 5 : Regenerated bindings #

Patch Set 6 : Collapsed all glQuery functions #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2352 lines, -2686 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View	1 2 3 4 5	7 chunks	+10 lines, -10 lines	0 comments	Download
M	gpu/command_buffer/service/gpu_tracer_unittest.cc	View	1 2 3 4 5	4 chunks	+10 lines, -10 lines	0 comments	Download
M	gpu/command_buffer/service/query_manager.cc	View	1 2 3 4 5	4 chunks	+6 lines, -6 lines	0 comments	Download
M	gpu/command_buffer/service/query_manager_unittest.cc	View	1 2 3 4 5	12 chunks	+25 lines, -25 lines	0 comments	Download
M	ui/gl/generate_bindings.py	View	1 2 3 4 5	8 chunks	+17 lines, -32 lines	0 comments	Download
M	ui/gl/gl_bindings_api_autogen_gl.h	View	1 2 3 4 5	6 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/gl/gl_bindings_autogen_gl.h	View	1 2 3 4 5	24 chunks	+0 lines, -47 lines	0 comments	Download
M	ui/gl/gl_bindings_autogen_gl.cc	View	1 2 3 4 5	54 chunks	+50 lines, -305 lines	0 comments	Download
M	ui/gl/gl_bindings_autogen_mock.cc	View	1 2 3 4 5	10 chunks	+16 lines, -16 lines	0 comments	Download
M	ui/gl/gl_enums_implementation_autogen.h	View	1 2 3 4	1 chunk	+2214 lines, -2214 lines	0 comments	Download
M	ui/gl/gl_mock_autogen_gl.h	View	1 2 3 4 5	6 chunks	+0 lines, -9 lines	0 comments	Download
M	ui/gl/gpu_timing.cc	View	1 2 3 4 5	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 12 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

no sievers

You also have to run ui/gl/generate_bindings.py for your changes to take effect. That's why the ...

5 years, 9 months ago (2015-03-16 19:14:29 UTC) #2

David Yen

On 2015/03/16 19:14:29, sievers wrote: > You also have to run ui/gl/generate_bindings.py for your changes ...

5 years, 9 months ago (2015-03-16 19:25:09 UTC) #3

no sievers

On 2015/03/16 19:25:09, David Yen wrote: > On 2015/03/16 19:14:29, sievers wrote: > > You ...

5 years, 9 months ago (2015-03-16 20:04:38 UTC) #4

David Yen

On 2015/03/16 20:04:38, sievers wrote: > On 2015/03/16 19:25:09, David Yen wrote: > > On ...

5 years, 9 months ago (2015-03-16 20:05:51 UTC) #5

no sievers

On 2015/03/16 20:05:51, David Yen wrote: > On 2015/03/16 20:04:38, sievers wrote: > > On ...

5 years, 9 months ago (2015-03-16 20:10:32 UTC) #6

David Yen

On 2015/03/16 20:10:32, sievers wrote: > On 2015/03/16 20:05:51, David Yen wrote: > > On ...

5 years, 9 months ago (2015-03-16 20:20:53 UTC) #7

On 2015/03/16 20:10:32, sievers wrote:
> On 2015/03/16 20:05:51, David Yen wrote:
> > On 2015/03/16 20:04:38, sievers wrote:
> > > On 2015/03/16 19:25:09, David Yen wrote:
> > > > On 2015/03/16 19:14:29, sievers wrote:
> > > > > You also have to run ui/gl/generate_bindings.py for your changes to
take
> > > > effect.
> > > > > 
> > > > > That's why the unittests are failing.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1006093002/diff/60001/ui/gl/generate_bindings.py
> > > > > File ui/gl/generate_bindings.py (right):
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1006093002/diff/60001/ui/gl/generate_bindings...
> > > > > ui/gl/generate_bindings.py:561: 'versions': [{ 'name': 'glGetQueryiv'
> }],
> > > > > These too.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1006093002/diff/60001/ui/gl/generate_bindings...
> > > > > ui/gl/generate_bindings.py:574: 'names': ['glGetQueryObjectiv'],
> > > > > This one.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1006093002/diff/60001/ui/gl/generate_bindings...
> > > > > ui/gl/generate_bindings.py:585: 'versions': [{ 'name':
> > 'glGetQueryObjectuiv'
> > > > }],
> > > > > This one.
> > > > > 
> > > > >
> > > >
> > >
> >
>
https://codereview.chromium.org/1006093002/diff/60001/ui/gl/generate_bindings...
> > > > > ui/gl/generate_bindings.py:709: 'versions': [{ 'name': 'glIsQuery' }],
> > > > > Merge these too.
> > > > 
> > > > I was planning on merging those in a separate CL.
> > > 
> > > Why? I'd just do them all together for consistency, since they belong
> > together.
> > > Unless it really somehow makes changing this way way easier... does it?
> > 
> > Only to minimize the changes to make reviewing easier. I can put them all in
1
> > CL too if you think that is easier.
> 
> Yea I think that's a nicer state than having an inconsistent mix of
> glSomethingQuery() and glSomethingElseQueryARB() in the interface.

Okay, I added all of the query related functions and updated the CL Description.
PTAL.

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1006093002/100001

5 years, 9 months ago (2015-03-16 21:49:31 UTC) #10

commit-bot: I haz the power

5 years, 9 months ago (2015-03-16 22:52:57 UTC) #12

Message was sent while issue was closed.

Patchset 6 (id:??) landed as
https://crrev.com/d09e8c398fffce740e3b8b62d4cef3d7341a3361
Cr-Commit-Position: refs/heads/master@{#320814}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages