favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]*

favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]*

BUG=466848
Committed: https://crrev.com/042582e3d43600e5aa88feffd72ccf48fc2c047f
Cr-Commit-Position: refs/heads/master@{#320804}

[Mostyn Bramley-Moore, 2015-03-13 09:55:52]

mostynb@opera.com changed reviewers:
+ sievers@chromium.org

[Mostyn Bramley-Moore, 2015-03-13 09:57:08]

@sievers: PTAL.

(I'm trying to spread the load around content/OWNERS a bit, so there are some
related issues submitted separately.)

[no sievers, 2015-03-13 20:17:17]

DCHECK_IS_CURRENTLY_ON() is a bit vague, and confusing with the existing
DCHECK_IS_ON().

Maybe DCHECK_CURRENT_THREAD_IS() or something like that?

[Mostyn Bramley-Moore, 2015-03-13 21:32:33]

mostynb@opera.com changed reviewers:
+ jyasskin@gmail.com

[Mostyn Bramley-Moore, 2015-03-13 21:32:54]

mostynb@opera.com changed reviewers:
+ jyasskin@chromium.org
- jyasskin@gmail.com

[Mostyn Bramley-Moore, 2015-03-13 21:47:49]

On 2015/03/13 20:17:17, sievers wrote:
> DCHECK_IS_CURRENTLY_ON() is a bit vague, and confusing with the existing
> DCHECK_IS_ON().
> 
> Maybe DCHECK_CURRENT_THREAD_IS() or something like that?

CC jyasskin, who originally added DCHECK_IS_CURRENTLY_ON.  The original
discussion of this macro was here: https://codereview.chromium.org/191763002

Personally, if I was choosing the name for these two macros to avoid ambiguity
and to be concise, I would use something like DCHECK_ENABLED() and
DCHECK_ON_THREAD(ID).  Is this change something you would like to push for
(renaming both or one of these)?  There are only 140 instances of DCHECK_IS_ON
to change, but 2272 instances of DCHECK_IS_CURRENTLY_ON.

[Jeffrey Yasskin, 2015-03-15 11:58:22]

On 2015/03/13 20:17:17, sievers wrote:
> DCHECK_IS_CURRENTLY_ON() is a bit vague, and confusing with the existing
> DCHECK_IS_ON().
> 
> Maybe DCHECK_CURRENT_THREAD_IS() or something like that?

DCHECK_IS_CURRENTLY_ON() doesn't compile, and
DCHECK_IS_CURRENTLY_ON(BrowserThread::Foo) is less confusing. It's also
inappropriate to make comments about taste in the middle of a global cleanup.

[no sievers, 2015-03-16 19:52:58]

LGTM given that it's already in use, and given that's an improvement in the
error message.

[Mostyn Bramley-Moore, 2015-03-16 21:02:55]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2015-03-16 21:03:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1005683003/1

[commit-bot: I haz the power, 2015-03-16 22:14:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-16 22:15:16]

Patchset 1 (id:??) landed as
https://crrev.com/042582e3d43600e5aa88feffd72ccf48fc2c047f
Cr-Commit-Position: refs/heads/master@{#320804}