content/browser/renderer_host/p2p/socket_dispatcher_host.cc - Issue 1005683003: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/p2p/socket_dispatcher_host.cc

Issue 1005683003: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/peer_connection_tracker_host.cc ('k') | content/browser/renderer_host/p2p/socket_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/p2p/socket_dispatcher_host.cc

diff --git a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc

index 2e3afbd64bc02098e0abedbc8b51e340f79091c2..913adf7710f14474db3d1c9a578f3a1c91b5a549 100644

--- a/content/browser/renderer_host/p2p/socket_dispatcher_host.cc

+++ b/content/browser/renderer_host/p2p/socket_dispatcher_host.cc

@@ -158,7 +158,7 @@ void P2PSocketDispatcherHost::StartRtpDump(

bool incoming,

bool outgoing,

const RenderProcessHost::WebRtcRtpPacketCallback& packet_callback) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(BrowserThread::IO);

if ((!dump_incoming_rtp_packet_ && incoming) ||

(!dump_outgoing_rtp_packet_ && outgoing)) {

@@ -176,7 +176,7 @@ void P2PSocketDispatcherHost::StartRtpDump(

void P2PSocketDispatcherHost::StopRtpDumpOnUIThread(bool incoming,

bool outgoing) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

BrowserThread::PostTask(

BrowserThread::IO,

FROM_HERE,