Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: content/browser/tracing/trace_message_filter.cc

Issue 1005683003: favor DCHECK_CURRENTLY_ON for better logs in content/browser/[q-z]* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/time_zone_monitor_linux.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/trace_message_filter.cc
diff --git a/content/browser/tracing/trace_message_filter.cc b/content/browser/tracing/trace_message_filter.cc
index e1dbdeb377d1b944bf83322ef5de691122ba0773..223fbd6186c54a532fce89848816d21ee062aed8 100644
--- a/content/browser/tracing/trace_message_filter.cc
+++ b/content/browser/tracing/trace_message_filter.cc
@@ -59,14 +59,14 @@ bool TraceMessageFilter::OnMessageReceived(const IPC::Message& message) {
void TraceMessageFilter::SendBeginTracing(
const base::trace_event::CategoryFilter& category_filter,
const base::trace_event::TraceOptions& options) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
Send(new TracingMsg_BeginTracing(category_filter.ToString(),
base::TimeTicks::NowFromSystemTraceTime(),
options.ToString()));
}
void TraceMessageFilter::SendEndTracing() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!is_awaiting_end_ack_);
is_awaiting_end_ack_ = true;
Send(new TracingMsg_EndTracing);
@@ -75,26 +75,26 @@ void TraceMessageFilter::SendEndTracing() {
void TraceMessageFilter::SendEnableMonitoring(
const base::trace_event::CategoryFilter& category_filter,
const base::trace_event::TraceOptions& options) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
Send(new TracingMsg_EnableMonitoring(category_filter.ToString(),
base::TimeTicks::NowFromSystemTraceTime(),
options.ToString()));
}
void TraceMessageFilter::SendDisableMonitoring() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
Send(new TracingMsg_DisableMonitoring);
}
void TraceMessageFilter::SendCaptureMonitoringSnapshot() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!is_awaiting_capture_monitoring_snapshot_ack_);
is_awaiting_capture_monitoring_snapshot_ack_ = true;
Send(new TracingMsg_CaptureMonitoringSnapshot);
}
void TraceMessageFilter::SendGetTraceLogStatus() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
DCHECK(!is_awaiting_buffer_percent_full_ack_);
is_awaiting_buffer_percent_full_ack_ = true;
Send(new TracingMsg_GetTraceLogStatus);
« no previous file with comments | « content/browser/time_zone_monitor_linux.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698