Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Issue 1005123002: MIPS64: Unify and improve Word32 compares to use same instructions as Word64 compares. (Closed)

Created:
5 years, 9 months ago by dusmil.imgtec
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Unify and improve Word32 compares to use same instructions as Word64 compares. The CL enables the same instructions are selected for Word32 and Word64 compare operations which is possible due to a fact 32-bit inputs and produced values are always sign-extended. TEST= BUG= Committed: https://crrev.com/17ada20c17d548a2a98f55ba7b16a00978679d48 Cr-Commit-Position: refs/heads/master@{#27212}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -157 lines) Patch
M src/compiler/mips64/code-generator-mips64.cc View 5 chunks +1 line, -95 lines 1 comment Download
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 8 chunks +7 lines, -44 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M test/cctest/compiler/call-tester.h View 2 chunks +17 lines, -0 lines 3 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 3 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
dusmil.imgtec
5 years, 9 months ago (2015-03-13 15:05:54 UTC) #2
paul.l...
LGTM. https://codereview.chromium.org/1005123002/diff/1/src/compiler/mips64/code-generator-mips64.cc File src/compiler/mips64/code-generator-mips64.cc (right): https://codereview.chromium.org/1005123002/diff/1/src/compiler/mips64/code-generator-mips64.cc#newcode825 src/compiler/mips64/code-generator-mips64.cc:825: // emit mips psuedo-instructions, which are handled here ...
5 years, 9 months ago (2015-03-13 17:05:31 UTC) #3
paul.l...
Also, this has a small change to cctest/compiler/call-tester.h that I cannot approve. Can someone from ...
5 years, 9 months ago (2015-03-13 17:08:06 UTC) #4
Benedikt Meurer
lgtm
5 years, 9 months ago (2015-03-13 18:24:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005123002/1
5 years, 9 months ago (2015-03-16 10:32:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 11:00:05 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/17ada20c17d548a2a98f55ba7b16a00978679d48 Cr-Commit-Position: refs/heads/master@{#27212}
5 years, 9 months ago (2015-03-16 11:00:18 UTC) #9
titzer
https://codereview.chromium.org/1005123002/diff/1/test/cctest/compiler/call-tester.h File test/cctest/compiler/call-tester.h (right): https://codereview.chromium.org/1005123002/diff/1/test/cctest/compiler/call-tester.h#newcode131 test/cctest/compiler/call-tester.h:131: #if V8_TARGET_ARCH_MIPS64 This should be good enough for all ...
5 years, 9 months ago (2015-03-24 14:37:22 UTC) #11
dusmil.imgtec
https://codereview.chromium.org/1005123002/diff/1/test/cctest/compiler/call-tester.h File test/cctest/compiler/call-tester.h (right): https://codereview.chromium.org/1005123002/diff/1/test/cctest/compiler/call-tester.h#newcode131 test/cctest/compiler/call-tester.h:131: #if V8_TARGET_ARCH_MIPS64 On 2015/03/24 14:37:22, titzer wrote: > This ...
5 years, 9 months ago (2015-03-24 18:41:12 UTC) #12
titzer
5 years, 9 months ago (2015-03-24 18:43:33 UTC) #13
Message was sent while issue was closed.
https://codereview.chromium.org/1005123002/diff/1/test/cctest/compiler/call-t...
File test/cctest/compiler/call-tester.h (right):

https://codereview.chromium.org/1005123002/diff/1/test/cctest/compiler/call-t...
test/cctest/compiler/call-tester.h:131: #if V8_TARGET_ARCH_MIPS64
On 2015/03/24 18:41:12, dusmil.imgtec wrote:
> On 2015/03/24 14:37:22, titzer wrote:
> > This should be good enough for all architectures, yes?
> Yes, after all this only concerns simulated architectures where host code and
> generated code are different.  Particularly this solves problem for mips64
> simulator builds where transition from x64 code to mips64 generated code is
> done.

If you remove the ifdef and it works on all platforms, I'll rubber-stamp it
tomorrow.

Sorry for the late comment, forgot to hit the button before it landed.

Powered by Google App Engine
This is Rietveld 408576698