Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1004623003: Revert of Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (Closed)

Created:
5 years, 9 months ago by Igor Sheludko
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (patchset #3 id:40001 of https://codereview.chromium.org/988363002/) Reason for revert: Increased rate of Chrome crashes. Requires further investigation. Original issue's description: > Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. > > The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). > This CL also adds useful machinery that helps triggering incremental write barriers. > > BUG=chromium:454297, chromium:465273 > LOG=Y > > Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a > Cr-Commit-Position: refs/heads/master@{#27141} TBR=hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:454297, chromium:465273 Committed: https://crrev.com/52cb51fb8dd9ec3f28856d4e6743aeabcd3806e2 Cr-Commit-Position: refs/heads/master@{#27207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -390 lines) Patch
M src/flag-definitions.h View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap/mark-compact.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +3 lines, -26 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/heap/store-buffer.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/heap/store-buffer.cc View 2 chunks +4 lines, -59 lines 0 comments Download
M src/objects.cc View 2 chunks +4 lines, -62 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +0 lines, -225 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Igor Sheludko
Created Revert of Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer.
5 years, 9 months ago (2015-03-16 09:40:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004623003/1
5 years, 9 months ago (2015-03-16 09:40:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 09:40:40 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 09:40:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/52cb51fb8dd9ec3f28856d4e6743aeabcd3806e2
Cr-Commit-Position: refs/heads/master@{#27207}

Powered by Google App Engine
This is Rietveld 408576698