Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 988363002: Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. (Closed)

Created:
5 years, 9 months ago by Igor Sheludko
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Remove slots that point to unboxed doubles from the StoreBuffer/SlotsBuffer. The problem is that tagged slot could become a double slot after migrating of an object to another map with "shifted" fields (for example as a result of generalizing immutable data property to a data field). This CL also adds useful machinery that helps triggering incremental write barriers. BUG=chromium:454297, chromium:465273 LOG=Y Committed: https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a Cr-Commit-Position: refs/heads/master@{#27141}

Patch Set 1 #

Patch Set 2 : The fix #

Patch Set 3 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -10 lines) Patch
M src/flag-definitions.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 3 chunks +26 lines, -3 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/heap/store-buffer.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/heap/store-buffer.cc View 1 2 2 chunks +58 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +62 lines, -4 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 2 chunks +225 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Igor Sheludko
PTAL
5 years, 9 months ago (2015-03-09 12:48:24 UTC) #2
Hannes Payer (out of office)
lgtm
5 years, 9 months ago (2015-03-09 20:00:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988363002/20001
5 years, 9 months ago (2015-03-11 18:43:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/3847)
5 years, 9 months ago (2015-03-11 18:45:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988363002/40001
5 years, 9 months ago (2015-03-11 19:28:28 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-11 19:29:57 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/6d0677d845c47ab9fa297de61d0e3d8e5480a02a Cr-Commit-Position: refs/heads/master@{#27141}
5 years, 9 months ago (2015-03-11 19:30:10 UTC) #12
Igor Sheludko
5 years, 9 months ago (2015-03-16 09:40:09 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1004623003/ by ishell@chromium.org.

The reason for reverting is: Increased rate of Chrome crashes. Requires further
investigation..

Powered by Google App Engine
This is Rietveld 408576698