Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1003923002: Revert of Add IsAlternativeServiceBroken(), remove is_broken. (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add IsAlternativeServiceBroken(), remove is_broken. (patchset #2 id:20001 of https://codereview.chromium.org/997953003/) Reason for revert: Crash! BUG=466706 Original issue's description: > Add IsAlternativeServiceBroken(), remove is_broken. > > Add HttpServerProperties::IsAlternativeServiceBroken(), remove > AlternateProtocolInfo.is_broken. An alternative service can be broken by > itself, not with respect to an origin. > > Patch Set 1 of this CL has been manually landed at https://crrev.com/995013004 > and then reverted at https://crrev.com/999893002. > > BUG=392576 > R=rch@chromium.org > > Committed: https://crrev.com/9825fc06585af7bf868804a13e9064975d4ec374 > Cr-Commit-Position: refs/heads/master@{#320189} TBR=rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=392576 Committed: https://crrev.com/3ef2f4e3bba8753a2added3e8afe8df67e22980f Cr-Commit-Position: refs/heads/master@{#320328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -105 lines) Patch
M net/http/http_network_transaction_unittest.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M net/http/http_server_properties.h View 3 chunks +18 lines, -6 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_server_properties_impl.cc View 5 chunks +15 lines, -37 lines 0 comments Download
M net/http/http_server_properties_impl_unittest.cc View 4 chunks +28 lines, -14 lines 0 comments Download
M net/http/http_server_properties_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M net/http/http_server_properties_manager.cc View 8 chunks +12 lines, -26 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Bence
Created Revert of Add IsAlternativeServiceBroken(), remove is_broken.
5 years, 9 months ago (2015-03-12 18:20:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003923002/1
5 years, 9 months ago (2015-03-12 18:21:32 UTC) #2
commit-bot: I haz the power
Failed to apply patch for net/http/http_server_properties.h: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-12 18:24:06 UTC) #4
Bence
Trying again, https://codereview.chromium.org/1002043002/ should fix it.
5 years, 9 months ago (2015-03-12 18:34:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1003923002/1
5 years, 9 months ago (2015-03-12 18:35:06 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 18:36:33 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 18:37:25 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ef2f4e3bba8753a2added3e8afe8df67e22980f
Cr-Commit-Position: refs/heads/master@{#320328}

Powered by Google App Engine
This is Rietveld 408576698