Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: net/http/http_network_transaction_unittest.cc

Issue 1003923002: Revert of Add IsAlternativeServiceBroken(), remove is_broken. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/http/http_server_properties.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_network_transaction_unittest.cc
diff --git a/net/http/http_network_transaction_unittest.cc b/net/http/http_network_transaction_unittest.cc
index aa1697483294bacbd641d580fc734200609885bc..e27fbcc263094440a321e79089a8f8846e2cfd83 100644
--- a/net/http/http_network_transaction_unittest.cc
+++ b/net/http/http_network_transaction_unittest.cc
@@ -8785,11 +8785,11 @@
base::WeakPtr<HttpServerProperties> http_server_properties =
session->http_server_properties();
- const HostPortPair host_port_pair = HostPortPair::FromURL(request.url);
// Port must be < 1024, or the header will be ignored (since initial port was
// port 80 (another restricted port).
http_server_properties->SetAlternateProtocol(
- host_port_pair, 666 /* port is ignored by MockConnect anyway */,
+ HostPortPair::FromURL(request.url),
+ 666 /* port is ignored by MockConnect anyway */,
AlternateProtocolFromNextProto(GetParam()), 1.0);
scoped_ptr<HttpTransaction> trans(
@@ -8810,12 +8810,10 @@
EXPECT_EQ("hello world", response_data);
const AlternateProtocolInfo alternate =
- http_server_properties->GetAlternateProtocol(host_port_pair);
+ http_server_properties->GetAlternateProtocol(
+ HostPortPair::FromURL(request.url));
EXPECT_NE(UNINITIALIZED_ALTERNATE_PROTOCOL, alternate.protocol);
- const AlternativeService alternative_service(
- alternate.protocol, host_port_pair.host(), alternate.port);
- EXPECT_TRUE(
- http_server_properties->IsAlternativeServiceBroken(alternative_service));
+ EXPECT_TRUE(alternate.is_broken);
}
TEST_P(HttpNetworkTransactionTest,
« no previous file with comments | « no previous file | net/http/http_server_properties.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698