Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 100363002: Introduce RenderFrameObserver. (Closed)

Created:
7 years ago by jam
Modified:
7 years ago
Reviewers:
nasko
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Introduce RenderFrameObserver. Right now this is empty other than IPC related methods. We can start using this to replace RenderViewObservers. Eventually we will remove RenderViewObserver. BUG=245126 R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238258

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -162 lines) Patch
M content/content_renderer.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/public/renderer/render_frame_observer.h View 1 chunk +18 lines, -106 lines 0 comments Download
A + content/public/renderer/render_frame_observer.cc View 1 chunk +20 lines, -20 lines 0 comments Download
A + content/public/renderer/render_frame_observer_tracker.h View 2 chunks +30 lines, -29 lines 0 comments Download
M content/renderer/render_frame_impl.h View 5 chunks +12 lines, -1 line 2 comments Download
M content/renderer/render_frame_impl.cc View 7 chunks +21 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
7 years ago (2013-12-02 22:52:06 UTC) #1
nasko
LGTM with a nit. https://codereview.chromium.org/100363002/diff/1/content/renderer/render_frame_impl.h File content/renderer/render_frame_impl.h (right): https://codereview.chromium.org/100363002/diff/1/content/renderer/render_frame_impl.h#newcode62 content/renderer/render_frame_impl.h:62: int routing_id() const { return ...
7 years ago (2013-12-03 00:07:33 UTC) #2
jam
7 years ago (2013-12-03 00:14:31 UTC) #3
https://codereview.chromium.org/100363002/diff/1/content/renderer/render_fram...
File content/renderer/render_frame_impl.h (right):

https://codereview.chromium.org/100363002/diff/1/content/renderer/render_fram...
content/renderer/render_frame_impl.h:62: int routing_id() const { return
routing_id_; }
On 2013/12/03 00:07:33, nasko wrote:
> nit: Why not keep the GetRoutingID() naming, which is present in RenderView?

just because in general we have unix_hacker accessors for simple getters

> I expect this will have to be in the public RenderFrame interface at some
point.

sure, in that point we can then move it? I tend to prefer to not adding methods
until we know they're needed. Who knows, maybe this won't be needed on RF and in
which case the unix_hacker getter is enough.

Powered by Google App Engine
This is Rietveld 408576698