Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: content/renderer/render_frame_impl.h

Issue 100363002: Introduce RenderFrameObserver. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/render_frame_observer_tracker.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
===================================================================
--- content/renderer/render_frame_impl.h (revision 238191)
+++ content/renderer/render_frame_impl.h (working copy)
@@ -10,6 +10,7 @@
#include "base/basictypes.h"
#include "base/files/file_path.h"
+#include "base/observer_list.h"
#include "base/process/process_handle.h"
#include "base/strings/string16.h"
#include "content/public/renderer/render_frame.h"
@@ -34,6 +35,7 @@
class PepperPluginInstanceImpl;
class RendererPpapiHost;
+class RenderFrameObserver;
class RenderViewImpl;
class RenderWidget;
class RenderWidgetFullscreenPepper;
@@ -57,6 +59,8 @@
// to using RenderFrame instead of RenderView.
RenderViewImpl* render_view() { return render_view_; }
+ int routing_id() const { return routing_id_; }
nasko 2013/12/03 00:07:33 nit: Why not keep the GetRoutingID() naming, which
jam 2013/12/03 00:14:31 just because in general we have unix_hacker access
+
// Returns the RenderWidget associated with this frame.
RenderWidget* GetRenderWidget();
@@ -301,8 +305,12 @@
RenderFrameImpl(RenderViewImpl* render_view, int32 routing_id);
private:
- int GetRoutingID() const;
+ friend class RenderFrameObserver;
+ // Functions to add and remove observers for this object.
+ void AddObserver(RenderFrameObserver* observer);
+ void RemoveObserver(RenderFrameObserver* observer);
+
RenderViewImpl* render_view_;
int routing_id_;
bool is_swapped_out_;
@@ -326,6 +334,9 @@
PepperPluginInstanceImpl* pepper_last_mouse_event_target_;
#endif
+ // All the registered observers.
+ ObserverList<RenderFrameObserver> observers_;
+
DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
};
« no previous file with comments | « content/public/renderer/render_frame_observer_tracker.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698