Introduce RenderFrameObserver.

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <set>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
+#include "base/observer_list.h"
 #include "base/process/process_handle.h"
 #include "base/strings/string16.h"
 #include "content/public/renderer/render_frame.h"
 #include "ipc/ipc_message.h"
 #include "third_party/WebKit/public/web/WebDataSource.h"
 #include "third_party/WebKit/public/web/WebFrameClient.h"
 
 class TransportDIB;
 
 namespace blink {
 class WebMouseEvent;
 struct WebCompositionUnderline;
 struct WebCursorInfo;
 }
 
 namespace gfx {
 class Range;
 class Rect;
 }
 
 namespace content {
 
 class PepperPluginInstanceImpl;
 class RendererPpapiHost;
+class RenderFrameObserver;
 class RenderViewImpl;
 class RenderWidget;
 class RenderWidgetFullscreenPepper;
 
 class CONTENT_EXPORT RenderFrameImpl
     : public RenderFrame,
       NON_EXPORTED_BASE(public blink::WebFrameClient) {
  public:
   // Creates a new RenderFrame. |render_view| is the RenderView object that this
   // frame belongs to.
   static RenderFrameImpl* Create(RenderViewImpl* render_view, int32 routing_id);
 
   // Used by content_layouttest_support to hook into the creation of
   // RenderFrameImpls.
   static void InstallCreateHook(
       RenderFrameImpl* (*create_render_frame_impl)(RenderViewImpl*, int32));
 
   virtual ~RenderFrameImpl();
 
   // TODO(jam): this is a temporary getter until all the code is transitioned
   // to using RenderFrame instead of RenderView.
   RenderViewImpl* render_view() { return render_view_; }
 
+  int routing_id() const { return routing_id_; }

[nasko, 2013/12/03 00:07:33]

nit: Why not keep the GetRoutingID() naming, which is present in RenderView? I
expect this will have to be in the public RenderFrame interface at some point.

[jam, 2013/12/03 00:14:31]

just because in general we have unix_hacker accessors for simple getters
sure, in that point we can then move it? I tend to prefer to not adding methods
until we know they're needed. Who knows, maybe this won't be needed on RF and in
which case the unix_hacker getter is enough.

+
   // Returns the RenderWidget associated with this frame.
   RenderWidget* GetRenderWidget();
 
 #if defined(ENABLE_PLUGINS)
   // Indicates that the given instance has been created.
   void PepperInstanceCreated(PepperPluginInstanceImpl* instance);
 
   // Indicates that the given instance is being destroyed. This is called from
   // the destructor, so it's important that the instance is not dereferenced
   // from this call.
@@ skipping 224 matching lines @@
       const blink::WebURL& url);
   virtual blink::WebString doNotTrackValue(blink::WebFrame* frame);
   virtual bool allowWebGL(blink::WebFrame* frame, bool default_value);
   virtual void didLoseWebGLContext(blink::WebFrame* frame,
                                    int arb_robustness_status_code);
 
  protected:
   RenderFrameImpl(RenderViewImpl* render_view, int32 routing_id);
 
  private:
-  int GetRoutingID() const;
+  friend class RenderFrameObserver;
+
+  // Functions to add and remove observers for this object.
+  void AddObserver(RenderFrameObserver* observer);
+  void RemoveObserver(RenderFrameObserver* observer);
 
   RenderViewImpl* render_view_;
   int routing_id_;
   bool is_swapped_out_;
   bool is_detaching_;
 
 #if defined(ENABLE_PLUGINS)
   typedef std::set<PepperPluginInstanceImpl*> PepperPluginSet;
   PepperPluginSet active_pepper_instances_;
 
   // Whether or not the focus is on a PPAPI plugin
   PepperPluginInstanceImpl* focused_pepper_plugin_;
 
   // Current text input composition text. Empty if no composition is in
   // progress.
   string16 pepper_composition_text_;
 
   // The plugin instance that received the last mouse event. It is set to NULL
   // if the last mouse event went to elements other than Pepper plugins.
   // |pepper_last_mouse_event_target_| is not owned by this class. We can know
   // about when it is destroyed via InstanceDeleted().
   PepperPluginInstanceImpl* pepper_last_mouse_event_target_;
 #endif
 
+  // All the registered observers.
+  ObserverList<RenderFrameObserver> observers_;
+
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_