DevTools: support scopes and iframes when debugging service workers.

DevTools: support scopes and iframes when debugging service workers.

BUG=463892
Committed: https://crrev.com/3ecb1b4b9acfcb64f2ce79460b80a07c4e45610d
Cr-Commit-Position: refs/heads/master@{#320555}

[pfeldman, 2015-03-13 17:36:49]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2015-03-13 18:01:52]

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:108: static
scoped_refptr<ServiceWorkerDevToolsAgentHost> GetMatchingServiceWorker(
drop static

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:127: static
ServiceWorkerDevToolsAgentHost::Set GetMatchingServiceWorkers(
ditto

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:308:
render_frame_host_ = render_frame_host;
UpdateURLs();

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:325: static bool
CollectURLs(std::set<GURL>* urls, FrameTreeNode* tree_node) {
move to namespace above

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:343: if
(new_hosts.find(pair.second) == new_hosts.end())
indentation

[pfeldman, 2015-03-13 18:05:36]

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
File content/browser/devtools/protocol/service_worker_handler.cc (right):

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:108: static
scoped_refptr<ServiceWorkerDevToolsAgentHost> GetMatchingServiceWorker(
On 2015/03/13 18:01:52, dgozman wrote:
> drop static

Done.

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:127: static
ServiceWorkerDevToolsAgentHost::Set GetMatchingServiceWorkers(
On 2015/03/13 18:01:52, dgozman wrote:
> ditto

Done.

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:308:
render_frame_host_ = render_frame_host;
On 2015/03/13 18:01:52, dgozman wrote:
> UpdateURLs();

Done.

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:325: static bool
CollectURLs(std::set<GURL>* urls, FrameTreeNode* tree_node) {
On 2015/03/13 18:01:52, dgozman wrote:
> move to namespace above

Done.

https://codereview.chromium.org/1003263002/diff/1/content/browser/devtools/pr...
content/browser/devtools/protocol/service_worker_handler.cc:343: if
(new_hosts.find(pair.second) == new_hosts.end())
On 2015/03/13 18:01:52, dgozman wrote:
> indentation

Done.

[dgozman, 2015-03-13 18:12:36]

lgtm

[pfeldman, 2015-03-13 18:36:50]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-03-13 18:36:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1003263002/#ps40001
(title: "rebaselined")

[commit-bot: I haz the power, 2015-03-13 18:37:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1003263002/40001

[commit-bot: I haz the power, 2015-03-13 20:03:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-13 20:04:43]

Patchset 3 (id:??) landed as
https://crrev.com/3ecb1b4b9acfcb64f2ce79460b80a07c4e45610d
Cr-Commit-Position: refs/heads/master@{#320555}