Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: content/browser/devtools/protocol/service_worker_handler.h

Issue 1003263002: DevTools: support scopes and iframes when debugging service workers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/protocol/service_worker_handler.h
diff --git a/content/browser/devtools/protocol/service_worker_handler.h b/content/browser/devtools/protocol/service_worker_handler.h
index 1ce2bb65cbc7c93b89bca2f723f682972498cc30..ba685028a2410993860aca0c6bcfed09e5a4cf0d 100644
--- a/content/browser/devtools/protocol/service_worker_handler.h
+++ b/content/browser/devtools/protocol/service_worker_handler.h
@@ -9,6 +9,7 @@
#include "base/memory/weak_ptr.h"
#include "content/browser/devtools/protocol/devtools_protocol_handler.h"
+#include "content/browser/devtools/service_worker_devtools_agent_host.h"
#include "content/browser/devtools/service_worker_devtools_manager.h"
#include "content/browser/service_worker/service_worker_info.h"
#include "content/public/browser/devtools_agent_host.h"
@@ -21,9 +22,8 @@
namespace content {
-class RenderFrameHost;
+class RenderFrameHostImpl;
class ServiceWorkerContextWrapper;
-class ServiceWorkerDevToolsAgentHost;
namespace devtools {
namespace service_worker {
@@ -36,9 +36,9 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
ServiceWorkerHandler();
~ServiceWorkerHandler() override;
- void SetRenderFrameHost(RenderFrameHost* render_frame_host);
+ void SetRenderFrameHost(RenderFrameHostImpl* render_frame_host);
void SetClient(scoped_ptr<Client> client);
- void SetURL(const GURL& url);
+ void UpdateHosts();
void Detached();
// Protocol 'service worker' domain implementation.
@@ -62,9 +62,8 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
void AgentHostClosed(DevToolsAgentHost* agent_host,
bool replaced_with_another_client) override;
- void ReportWorkerCreated(DevToolsAgentHost* host, bool new_worker);
-
- bool MatchesInspectedPage(ServiceWorkerDevToolsAgentHost* host);
+ void ReportWorkerCreated(ServiceWorkerDevToolsAgentHost* host);
+ void ReportWorkerTerminated(ServiceWorkerDevToolsAgentHost* host);
void OnWorkerRegistrationUpdated(
const std::vector<ServiceWorkerRegistrationInfo>& registrations);
@@ -74,12 +73,11 @@ class ServiceWorkerHandler : public DevToolsAgentHostClient,
scoped_refptr<ServiceWorkerContextWrapper> context_;
scoped_ptr<Client> client_;
- using AttachedHosts = std::map<
- std::string, scoped_refptr<ServiceWorkerDevToolsAgentHost>>;
- AttachedHosts attached_hosts_;
+ ServiceWorkerDevToolsAgentHost::Map attached_hosts_;
bool enabled_;
- GURL url_;
+ std::set<GURL> urls_;
scoped_refptr<ContextObserver> context_observer_;
+ RenderFrameHostImpl* render_frame_host_;
base::WeakPtrFactory<ServiceWorkerHandler> weak_factory_;
« no previous file with comments | « no previous file | content/browser/devtools/protocol/service_worker_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698