Add a few missing "self = [super init..." notices by the clang static analyzer.

Add a few missing "self = [super init..." notices by the clang static analyzer.

BUG=none
TEST=none
TBR=dimich

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=131621

[Dmitry Titov, 2012-04-09 23:20:26]

Drive-by: Why an early return in the first file? Is there some threshold on the
size of the initializer when it's better to do an early return?

[Nico, 2012-04-09 23:30:35]

On 2012/04/09 23:20:26, Dmitry Titov wrote:
> Drive-by: Why an early return in the first file? Is there some threshold on
the
> size of the initializer when it's better to do an early return?

We normally never do early returns in chrome as far as I can tell. Avi wrote
that file, I was hoping he's tell to indent everything. Mostly done to keep the
diff small, I can change it to not early return too.

[Avi (use Gerrit), 2012-04-10 03:28:34]

LGTM

Re the external protocol dialog, what the hell was I thinking? It needs to be
split into initialization and running...

[commit-bot: I haz the power, 2012-04-10 16:39:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10031018/1

[commit-bot: I haz the power, 2012-04-10 16:39:15]

Presubmit check for 10031018-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/panels

[Nico, 2012-04-10 17:25:37]

dimich: Can you LGTM for panels/OWNERS?

[commit-bot: I haz the power, 2012-04-10 18:46:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/10031018/1

[commit-bot: I haz the power, 2012-04-10 20:21:44]

Change committed as 131621