chrome/browser/ui/panels/panel_window_controller_cocoa.mm - Issue 10031018: Add a few missing "self = [super init..." notices by the clang static analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 10031018: Add a few missing "self = [super init..." notices by the clang static analyzer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

index 8538f2abacea322e5ef83cd1c0899a2d49aa7087..364f21f869a4ad8d27160ad0463a290bd446400d 100644

--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

@@ -414,9 +414,9 @@ enum {

windowShim_.reset(window);

animateOnBoundsChange_ = YES;

canBecomeKeyWindow_ = YES;

+ contentsController_.reset(

+ [[TabContentsController alloc] initWithContents:nil]);

}

- contentsController_.reset(

- [[TabContentsController alloc] initWithContents:nil]);

return self;

}

« no previous file with comments | « chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm ('k') | no next file » | no next file with comments »