bindings: Use Maybe APIs in V8ScriptRunner (part 1)

Source/bindings/core/v8/ScriptStreamerTest.cpp

Index: Source/bindings/core/v8/ScriptStreamerTest.cpp
diff --git a/Source/bindings/core/v8/ScriptStreamerTest.cpp b/Source/bindings/core/v8/ScriptStreamerTest.cpp
index 27bec55e26f84be6d9010df2e4204c90d9316d37..204636b893be6514860ac5a39f1324b2bb03bd47 100644
--- a/Source/bindings/core/v8/ScriptStreamerTest.cpp
+++ b/Source/bindings/core/v8/ScriptStreamerTest.cpp
@@ -162,7 +162,7 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScript)
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();

[haraken, 2015/03/13 04:31:16]

Can we use ToLocal? (i.e., we might not want to introduce ToLocalChecked to
bindings/.) The following script.IsEmpty() would be enough.

[Yuki, 2015/03/13 04:39:41]

optional:

Reading v8.h:
  V8_INLINE Local<T> ToLocalChecked() {
    // TODO(dcarney): add DCHECK.
    return Local<T>(val_);
  }

ToLocalChecked should be named ToLocalDChecked or something like that.  It seems
not going to be checked in case of release build.

You may want to RELEASE_ASSERT version of ToLocalChecked, too.
You may send feedback to V8 team about this point.

[bashi, 2015/03/13 05:15:20]

Done.

     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
@@ -195,7 +195,7 @@ TEST_F(ScriptStreamingTest, CompilingStreamedScriptWithParseError)
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_TRUE(script.IsEmpty());
     EXPECT_TRUE(tryCatch.HasCaught());
 }
@@ -326,7 +326,7 @@ TEST_F(ScriptStreamingTest, ScriptsWithSmallFirstChunk)
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
@@ -354,7 +354,7 @@ TEST_F(ScriptStreamingTest, EncodingChanges)
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
@@ -382,7 +382,7 @@ TEST_F(ScriptStreamingTest, EncodingFromBOM)
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }