bindings: Use Maybe APIs in V8ScriptRunner (part 1)

Source/bindings/core/v8/PrivateScriptRunner.cpp

Index: Source/bindings/core/v8/PrivateScriptRunner.cpp
diff --git a/Source/bindings/core/v8/PrivateScriptRunner.cpp b/Source/bindings/core/v8/PrivateScriptRunner.cpp
index c3df1604ff9e95f346e4bef86676efdc058b5036..fdb59522cd589bfb00afda695feea10e377e2380 100644
--- a/Source/bindings/core/v8/PrivateScriptRunner.cpp
+++ b/Source/bindings/core/v8/PrivateScriptRunner.cpp
@@ -59,17 +59,20 @@ static v8::Handle<v8::Value> compileAndRunPrivateScript(v8::Isolate* isolate, St
             privateScriptControllerObject->Set(v8String(isolate, "import"), v8::FunctionTemplate::New(isolate, importFunction)->GetFunction());
     }
 
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(v8String(isolate, sourceString), fileName, String(), TextPosition::minimumPosition(), isolate, nullptr, nullptr, nullptr, NotSharableCrossOrigin);
-    if (block.HasCaught()) {
+    v8::Local<v8::Script> script;
+    if (!V8ScriptRunner::compileScript(v8String(isolate, sourceString), fileName, String(), TextPosition::minimumPosition(), isolate, nullptr, nullptr, nullptr, NotSharableCrossOrigin).ToLocal(&script)) {
         fprintf(stderr, "Private script error: Compile failed. (Class name = %s)\n", scriptClassName.utf8().data());
-        dumpV8Message(block.Message());
+        if (block.HasCaught())

[haraken, 2015/03/13 04:31:16]

Just to confirm: When a worker termination is signaled and the compileScript
returns false, V8 does not throw any exception, right? Is it an expected
behavior?

I'm asking this because except for the worker termination, it is guaranteed that
the compileScript returns false if and only if V8 throws an exception. In other
words, except for the worker termination, block.HasCaught() is guaranteed to be
true here.

[bashi, 2015/03/13 05:15:20]

I'm not fully confident, but I think you are right. Changed to use ASSERT().

+            dumpV8Message(block.Message());
         RELEASE_ASSERT_NOT_REACHED();
     }
 
-    v8::Handle<v8::Value> result = V8ScriptRunner::runCompiledInternalScript(isolate, script);
-    if (block.HasCaught()) {
-        fprintf(stderr, "Private script error: installClass() failed. (Class name = %s)\n", scriptClassName.utf8().data());
-        dumpV8Message(block.Message());
+    v8::Local<v8::Value> result;
+    if (!V8ScriptRunner::runCompiledInternalScript(isolate, script).ToLocal(&result)) {
+        if (block.HasCaught()) {
+            fprintf(stderr, "Private script error: installClass() failed. (Class name = %s)\n", scriptClassName.utf8().data());
+            dumpV8Message(block.Message());
+        }
         RELEASE_ASSERT_NOT_REACHED();
     }
     return result;