bindings: Use Maybe APIs in V8ScriptRunner (part 1)

Source/bindings/core/v8/ScriptStreamerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 
 #include "config.h"
 #include "bindings/core/v8/ScriptStreamer.h"
 
 #include "bindings/core/v8/ScriptSourceCode.h"
 #include "bindings/core/v8/ScriptStreamerThread.h"
@@ skipping 144 matching lines @@
 
     // Process tasks on the main thread until the streaming background thread
     // has completed its tasks.
     processTasksUntilStreamingComplete();
     EXPECT_TRUE(client.finished());
     bool errorOccurred = false;
     ScriptSourceCode sourceCode = pendingScript().getSource(KURL(), errorOccurred);
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();

[haraken, 2015/03/13 04:31:16]

Can we use ToLocal? (i.e., we might not want to introduce ToLocalChecked to
bindings/.) The following script.IsEmpty() would be enough.

[Yuki, 2015/03/13 04:39:41]

optional:

Reading v8.h:
  V8_INLINE Local<T> ToLocalChecked() {
    // TODO(dcarney): add DCHECK.
    return Local<T>(val_);
  }

ToLocalChecked should be named ToLocalDChecked or something like that.  It seems
not going to be checked in case of release build.

You may want to RELEASE_ASSERT version of ToLocalChecked, too.
You may send feedback to V8 team about this point.

[bashi, 2015/03/13 05:15:20]

Done.

     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
 
 TEST_F(ScriptStreamingTest, CompilingStreamedScriptWithParseError)
 {
     // Test that scripts with parse errors are handled properly. In those cases,
     // the V8 side typically finished before loading finishes: make sure we
     // handle it gracefully.
     ScriptStreamer::startStreaming(pendingScript(), m_settings.get(), m_scope.scriptState());
@@ skipping 12 matching lines @@
     EXPECT_FALSE(client.finished());
 
     finish();
     EXPECT_TRUE(client.finished());
 
     bool errorOccurred = false;
     ScriptSourceCode sourceCode = pendingScript().getSource(KURL(), errorOccurred);
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_TRUE(script.IsEmpty());
     EXPECT_TRUE(tryCatch.HasCaught());
 }
 
 TEST_F(ScriptStreamingTest, CancellingStreaming)
 {
     // Test that the upper layers (PendingScript and up) can be ramped down
     // while streaming is ongoing, and ScriptStreamer handles it gracefully.
     ScriptStreamer::startStreaming(pendingScript(), m_settings.get(), m_scope.scriptState());
     TestScriptResourceClient client;
@@ skipping 110 matching lines @@
 
     finish();
 
     processTasksUntilStreamingComplete();
     EXPECT_TRUE(client.finished());
     bool errorOccurred = false;
     ScriptSourceCode sourceCode = pendingScript().getSource(KURL(), errorOccurred);
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
 
 TEST_F(ScriptStreamingTest, EncodingChanges)
 {
     // It's possible that the encoding of the Resource changes after we start
     // loading it.
     m_resource->setEncoding("windows-1252");
 
     ScriptStreamer::startStreaming(pendingScript(), m_settings.get(), m_scope.scriptState());
     TestScriptResourceClient client;
     pendingScript().watchForLoad(&client);
 
     m_resource->setEncoding("UTF-8");
     // \xec\x92\x81 are the raw bytes for \uc481.
     appendData("function foo() { var foob\xec\x92\x81r = 13; return foob\xec\x92\x81r; } foo();");
 
     finish();
 
     processTasksUntilStreamingComplete();
     EXPECT_TRUE(client.finished());
     bool errorOccurred = false;
     ScriptSourceCode sourceCode = pendingScript().getSource(KURL(), errorOccurred);
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
 
 
 TEST_F(ScriptStreamingTest, EncodingFromBOM)
 {
     // Byte order marks should be removed before giving the data to V8. They
     // will also affect encoding detection.
     m_resource->setEncoding("windows-1252"); // This encoding is wrong on purpose.
 
     ScriptStreamer::startStreaming(pendingScript(), m_settings.get(), m_scope.scriptState());
     TestScriptResourceClient client;
     pendingScript().watchForLoad(&client);
 
     // \xef\xbb\xbf is the UTF-8 byte order mark. \xec\x92\x81 are the raw bytes
     // for \uc481.
     appendData("\xef\xbb\xbf function foo() { var foob\xec\x92\x81r = 13; return foob\xec\x92\x81r; } foo();");
 
     finish();
     processTasksUntilStreamingComplete();
     EXPECT_TRUE(client.finished());
     bool errorOccurred = false;
     ScriptSourceCode sourceCode = pendingScript().getSource(KURL(), errorOccurred);
     EXPECT_FALSE(errorOccurred);
     EXPECT_TRUE(sourceCode.streamer());
     v8::TryCatch tryCatch;
-    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate());
+    v8::Handle<v8::Script> script = V8ScriptRunner::compileScript(sourceCode, isolate()).ToLocalChecked();
     EXPECT_FALSE(script.IsEmpty());
     EXPECT_FALSE(tryCatch.HasCaught());
 }
 
 } // namespace
 
 } // namespace blink