Ensure we properly set PageTransition for iframes.

content/browser/frame_host/render_frame_host_impl.cc

Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index d38f2b35cce2bd8ccc1dcb9ddbb6823e3d6c0b41..fbb185b2b45be4e63c753b670812cd91b9417806 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1616,8 +1616,14 @@ void RenderFrameHostImpl::OpenURL(const FrameHostMsg_OpenURL_Params& params,
 
   TRACE_EVENT1("navigation", "RenderFrameHostImpl::OpenURL", "url",
                validated_url.possibly_invalid_spec());
+  ui::PageTransition transition = ui::PAGE_TRANSITION_LINK;
+  if (frame_tree_node_->parent()) {
+    transition = params.should_replace_current_entry

[Charlie Reis, 2015/04/22 20:44:57]

Maybe we should be preserving the actual transition from the renderer process?

I imagine we could put it into FrameHostMsg_OpenURL_Params in
RenderFrameImpl::OpenURL, getting it from the NavigationState.  That would
preserve masks like PAGE_TRANSITION_FORWARD_BACK.

[Nate Chapin, 2015/04/22 21:59:23]

That doesn't really work, because the NavigationState's transition type doesn't
get set until after we make the policy decision that could lead to a
FrameHostMsg_OpenURL. Also, RenderFrameProxy doesn't have very robust
information from which to calculate the PageTransition.

[Charlie Reis, 2015/04/22 22:04:29]

Ok.  I'll defer on this, since we should be able to get rid of OpenURL once
PlzNavigate is done.

+        ? ui::PAGE_TRANSITION_AUTO_SUBFRAME
+        : ui::PAGE_TRANSITION_MANUAL_SUBFRAME;
+  }
   frame_tree_node_->navigator()->RequestOpenURL(
-      this, validated_url, source_site_instance, params.referrer,
+      this, validated_url, source_site_instance, params.referrer, transition,
       params.disposition, params.should_replace_current_entry,
       params.user_gesture);
 }