Ensure we properly set PageTransition for iframes.

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/containers/hash_tables.h"
 #include "base/lazy_instance.h"
@@ skipping 1598 matching lines @@
   Navigate(common_params, StartNavigationParams(), RequestNavigationParams());
 }
 
 void RenderFrameHostImpl::OpenURL(const FrameHostMsg_OpenURL_Params& params,
                                   SiteInstance* source_site_instance) {
   GURL validated_url(params.url);
   GetProcess()->FilterURL(false, &validated_url);
 
   TRACE_EVENT1("navigation", "RenderFrameHostImpl::OpenURL", "url",
                validated_url.possibly_invalid_spec());
+  ui::PageTransition transition = ui::PAGE_TRANSITION_LINK;
+  if (frame_tree_node_->parent()) {
+    transition = params.should_replace_current_entry

[Charlie Reis, 2015/04/22 20:44:57]

Maybe we should be preserving the actual transition from the renderer process?

I imagine we could put it into FrameHostMsg_OpenURL_Params in
RenderFrameImpl::OpenURL, getting it from the NavigationState.  That would
preserve masks like PAGE_TRANSITION_FORWARD_BACK.

[Nate Chapin, 2015/04/22 21:59:23]

That doesn't really work, because the NavigationState's transition type doesn't
get set until after we make the policy decision that could lead to a
FrameHostMsg_OpenURL. Also, RenderFrameProxy doesn't have very robust
information from which to calculate the PageTransition.

[Charlie Reis, 2015/04/22 22:04:29]

Ok.  I'll defer on this, since we should be able to get rid of OpenURL once
PlzNavigate is done.

+        ? ui::PAGE_TRANSITION_AUTO_SUBFRAME
+        : ui::PAGE_TRANSITION_MANUAL_SUBFRAME;
+  }
   frame_tree_node_->navigator()->RequestOpenURL(
-      this, validated_url, source_site_instance, params.referrer,
+      this, validated_url, source_site_instance, params.referrer, transition,
       params.disposition, params.should_replace_current_entry,
       params.user_gesture);
 }
 
 void RenderFrameHostImpl::Stop() {
   Send(new FrameMsg_Stop(routing_id_));
 }
 
 void RenderFrameHostImpl::DispatchBeforeUnload(bool for_navigation) {
   // TODO(creis): Support beforeunload on subframes.  For now just pretend that
@@ skipping 370 matching lines @@
     return;
 
   permission_manager->RegisterPermissionUsage(
       PermissionType::GEOLOCATION,
       GetLastCommittedURL().GetOrigin(),
       frame_tree_node()->frame_tree()->GetMainFrame()
           ->GetLastCommittedURL().GetOrigin());
 }
 
 }  // namespace content