content/browser/frame_host/navigator_impl.cc - Issue 1002953004: Ensure we properly set PageTransition for iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 1002953004: Ensure we properly set PageTransition for iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl.cc

diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc

index fd59de25c324c7bebe2e9f46604ce172cc70f7e5..32e3d50d6881f194b357dc7b8bb803ce5f00e381 100644

--- a/content/browser/frame_host/navigator_impl.cc

+++ b/content/browser/frame_host/navigator_impl.cc

@@ -514,6 +514,7 @@ void NavigatorImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,

const GURL& url,

SiteInstance* source_site_instance,

const Referrer& referrer,

+ ui::PageTransition page_transition,

WindowOpenDisposition disposition,

bool should_replace_current_entry,

bool user_gesture) {

@@ -535,7 +536,7 @@ void NavigatorImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,

// redirects. http://crbug.com/311721.

std::vector<GURL> redirect_chain;

RequestTransferURL(render_frame_host, url, source_site_instance,

- redirect_chain, referrer, ui::PAGE_TRANSITION_LINK,

+ redirect_chain, referrer, page_transition,

disposition, GlobalRequestID(),

should_replace_current_entry, user_gesture);

}