Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: content/common/frame_messages.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with android Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 32052dfae193c253d81c33fe5fd23c2e32766f51..b8c526263910cd5669379d721cc4b7acbf2efe8d 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -112,6 +112,9 @@ IPC_STRUCT_END()
IPC_STRUCT_BEGIN(FrameHostMsg_DidFailProvisionalLoadWithError_Params)
// Error code as reported in the DidFailProvisionalLoad callback.
IPC_STRUCT_MEMBER(int, error_code)
+ // The unique id of the navigation that failed. If the failure was of a
+ // renderer-initiated navigation, this will be 0.
+ IPC_STRUCT_MEMBER(int, nav_entry_id)
nasko 2015/04/27 14:03:56 Tracing through the path of this IPC message, I ca
Avi (use Gerrit) 2015/04/27 14:56:33 I removed the part of the code that used this, but
// An error message generated from the error_code. This can be an empty
// string if we were unable to find a meaningful description.
IPC_STRUCT_MEMBER(base::string16, error_description)
@@ -124,6 +127,7 @@ IPC_STRUCT_END()
IPC_STRUCT_TRAITS_BEGIN(content::FrameNavigateParams)
IPC_STRUCT_TRAITS_MEMBER(page_id)
+ IPC_STRUCT_TRAITS_MEMBER(nav_entry_id)
IPC_STRUCT_TRAITS_MEMBER(url)
IPC_STRUCT_TRAITS_MEMBER(base_url)
IPC_STRUCT_TRAITS_MEMBER(referrer)
@@ -142,6 +146,15 @@ IPC_STRUCT_BEGIN_WITH_PARENT(FrameHostMsg_DidCommitProvisionalLoad_Params,
content::FrameNavigateParams)
IPC_STRUCT_TRAITS_PARENT(content::FrameNavigateParams)
+ // This is the value from the browser indicated whether it intended to make a
+ // new entry. TODO(avi): Remove this when the pending entry situation is made
+ // sane and the browser keeps them around long enough to match them via
+ // nav_entry_id.
+ IPC_STRUCT_MEMBER(bool, intended_as_new_entry)
+
+ // Whether this commit created a new entry.
+ IPC_STRUCT_MEMBER(bool, did_create_new_entry)
+
// Information regarding the security of the connection (empty if the
// connection was not secure).
IPC_STRUCT_MEMBER(std::string, security_info)
@@ -273,6 +286,8 @@ IPC_STRUCT_TRAITS_BEGIN(content::RequestNavigationParams)
IPC_STRUCT_TRAITS_MEMBER(request_time)
IPC_STRUCT_TRAITS_MEMBER(page_state)
IPC_STRUCT_TRAITS_MEMBER(page_id)
+ IPC_STRUCT_TRAITS_MEMBER(nav_entry_id)
+ IPC_STRUCT_TRAITS_MEMBER(intended_as_new_entry)
IPC_STRUCT_TRAITS_MEMBER(pending_history_list_offset)
IPC_STRUCT_TRAITS_MEMBER(current_history_list_offset)
IPC_STRUCT_TRAITS_MEMBER(current_history_list_length)

Powered by Google App Engine
This is Rietveld 408576698