chrome/browser/geolocation/geolocation_permission_context_unittest.cc - Issue 1002803002: Classify navigations without page id in parallel to the existing classifier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: with android Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/offline/offline_load_page_unittest.cc ('k') | chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc » ('j') | content/common/frame_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/geolocation/geolocation_permission_context_unittest.cc

diff --git a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

index 37e840620f4f0be3d2a75a35fe0d92156f3f3009..677508735cb18e6ca3ddf63b519467aa20f0a3f3 100644

--- a/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

+++ b/chrome/browser/geolocation/geolocation_permission_context_unittest.cc

@@ -32,6 +32,7 @@

#include "components/infobars/core/infobar.h"

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/navigation_details.h"

+#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/notification_observer.h"

#include "content/public/browser/notification_registrar.h"

#include "content/public/browser/notification_service.h"

@@ -224,8 +225,9 @@ void GeolocationPermissionContextTests::AddNewTab(const GURL& url) {

content::WebContents* new_tab = CreateTestWebContents();

new_tab->GetController().LoadURL(

url, content::Referrer(), ui::PAGE_TRANSITION_TYPED, std::string());

+ content::NavigationEntry* entry = new_tab->GetController().GetPendingEntry();

content::RenderFrameHostTester::For(new_tab->GetMainFrame())

- ->SendNavigate(extra_tabs_.size() + 1, url);

+ ->SendNavigate(extra_tabs_.size() + 1, entry->GetUniqueID(), true, url);

Michael van Ouwerkerk 2015/04/27 11:20:25 What does |true| stand for? Maybe add a comment li

Avi (use Gerrit) 2015/04/27 14:56:33 true is for did_create_new_entry. I can't comment

// Set up required helpers, and make this be as "tabby" as the code requires.

#if defined(ENABLE_EXTENSIONS)