Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/common/navigation_params.h

Issue 1002803002: Classify navigations without page id in parallel to the existing classifier. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with android Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index cba83c67b19b97132fbe2f161127a44121d68ee8..90eb70eea510f864d13bb13e4dc942b7df3d05ca 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -169,6 +169,8 @@ struct CONTENT_EXPORT RequestNavigationParams {
base::Time request_time,
const PageState& page_state,
int32 page_id,
+ int nav_entry_id,
+ bool intended_as_new_entry,
int pending_history_list_offset,
int current_history_list_offset,
int current_history_list_length,
@@ -203,6 +205,18 @@ struct CONTENT_EXPORT RequestNavigationParams {
// FrameHostMsg_DidCommitProvisionalLoad message.
int32 page_id;
+ // For browser-initiated navigations, this is the unique id of the
+ // NavigationEntry being navigated to. (For renderer-initiated navigations it
+ // is 0.) If the load succeeds, then this nav_entry_id will be reflected in
+ // the resulting FrameHostMsg_DidCommitProvisionalLoad message.
+ int nav_entry_id;
+
+ // For browser-initiated navigations, this is true if this is a new entry
+ // being navigated to. This is false otherwise. TODO(avi): Remove this when
+ // the pending entry situation is made sane and the browser keeps them around
+ // long enough to match them via nav_entry_id, above.
+ bool intended_as_new_entry;
+
// For history navigations, this is the offset in the history list of the
// pending load. For non-history navigations, this will be ignored.
int pending_history_list_offset;

Powered by Google App Engine
This is Rietveld 408576698