Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1002523007: Removed arbitrary 4096 size limit on WebGL canvas backbuffers (Closed)

Created:
5 years, 9 months ago by bajones
Modified:
5 years, 7 months ago
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-html_chromium.org, Rik, dglazkov+blink, dshwang, Justin Novosad
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Removed arbitrary 4096 size limit on WebGL canvas backbuffers BUG=445542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192222

Patch Set 1 #

Patch Set 2 : Testing potential fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -13 lines) Patch
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 6 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bajones
5 years, 9 months ago (2015-03-19 20:31:39 UTC) #2
Zhenyao Mo
On 2015/03/19 20:31:39, bajones wrote: LGTM
5 years, 9 months ago (2015-03-19 20:35:04 UTC) #3
Ken Russell (switch to Gerrit)
Argh. LGTM
5 years, 9 months ago (2015-03-19 22:53:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002523007/1
5 years, 9 months ago (2015-03-19 22:57:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=192222
5 years, 9 months ago (2015-03-20 03:15:14 UTC) #7
Corentin Wallez
5 years, 9 months ago (2015-03-20 14:58:16 UTC) #8
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1022113002/ by cwallez@chromium.org.

The reason for reverting is: Suspected to break GPU bots, in the regression
range of
http://build.chromium.org/p/chromium.gpu/builders/Win7%20Release%20%28NVIDIA%...
which fails with
WebglConformance.conformance_canvas_drawingbuffer_static_canvas_test. Another
bot has the following error for that test so it could be related
[1263:1287:0319/210147:INFO:CONSOLE(11)] "gl.drawingBufferWidth == 50 should be
true. Was false.", source:  (11)
http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%2010.9%20%28In....

Powered by Google App Engine
This is Rietveld 408576698