|
[Sync] Introduce AttachmentStoreForSync class
In this change:
- Add AttachmentStoreForSync class. It has functions that will be called by AttachmentServiceImpl to manage sync’s references to attachments.
- Change AttachmentServiceImpl to call those functions. The rule is that for all attachments that we start uploading call AddSyncReference, for all attachments that we no longer upload (for whatever reason) call DropSyncReference.
Couple of notes:
- There is no storage implementation for those functions, it will come in the next change.
- There is growing confusion between AttachmentIdSet and AttachmentIdList. I’ll resolve this next week in a separate change.
BUG= 457735
R=maniscalco@chromium.org
TEST=No user facing behavior. Change covered by sync_unit_tests.
Committed: https://crrev.com/dc577c86a31224a121b37e0f46e6de8f5e7f6435
Cr-Commit-Position: refs/heads/master@{#322263}
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+257 lines, -116 lines) |
Patch |
 |
M |
chrome/browser/sync/profile_sync_components_factory_impl.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_impl.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_mock.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/sync/profile_sync_components_factory_mock.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/device_info_data_type_controller_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/generic_change_processor.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/generic_change_processor.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/generic_change_processor_unittest.cc
|
View
|
1
2
|
4 chunks |
+5 lines, -4 lines |
0 comments
|
Download
|
 |
M |
components/sync_driver/shared_change_processor_unittest.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/sync_api_component_factory.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
components/sync_driver/ui_data_type_controller_unittest.cc
|
View
|
1
2
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/api/attachments/attachment_store.h
|
View
|
1
2
|
4 chunks |
+37 lines, -7 lines |
0 comments
|
Download
|
 |
M |
sync/api/attachments/attachment_store.cc
|
View
|
1
2
|
4 chunks |
+33 lines, -10 lines |
0 comments
|
Download
|
 |
M |
sync/api/attachments/attachment_store_backend.h
|
View
|
1
2
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
sync/api/fake_syncable_service.h
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
sync/api/fake_syncable_service.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/api/syncable_service.h
|
View
|
|
1 chunk |
+9 lines, -8 lines |
0 comments
|
Download
|
 |
M |
sync/api/syncable_service.cc
|
View
|
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/attachment_service_impl.cc
|
View
|
1
2
|
6 chunks |
+12 lines, -7 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/attachment_service_impl_unittest.cc
|
View
|
1
2
|
11 chunks |
+24 lines, -10 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/attachment_store_frontend.cc
|
View
|
1
2
|
2 chunks |
+16 lines, -8 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/attachment_store_frontend_unittest.cc
|
View
|
1
2
|
12 chunks |
+32 lines, -16 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/attachment_store_test_template.h
|
View
|
|
2 chunks |
+8 lines, -0 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/in_memory_attachment_store.cc
|
View
|
1
2
|
3 chunks |
+17 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/attachments/on_disk_attachment_store.cc
|
View
|
1
2
|
3 chunks |
+17 lines, -4 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/attachments/attachment_service_impl.h
|
View
|
1
2
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/attachments/attachment_store_frontend.h
|
View
|
1
2
|
1 chunk |
+7 lines, -6 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/attachments/in_memory_attachment_store.h
|
View
|
1
2
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
 |
M |
sync/internal_api/public/attachments/on_disk_attachment_store.h
|
View
|
1
2
|
1 chunk |
+7 lines, -5 lines |
0 comments
|
Download
|
Total messages: 9 (2 generated)
|