Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: sync/internal_api/attachments/on_disk_attachment_store.cc

Issue 1002263005: [Sync] Introduce AttachmentStoreForSync class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/on_disk_attachment_store.cc
diff --git a/sync/internal_api/attachments/on_disk_attachment_store.cc b/sync/internal_api/attachments/on_disk_attachment_store.cc
index 699e1f5add122106a7f7030881e3c9731d295c2d..98ccae4445203464ce79673fc061e3d50ccb070a 100644
--- a/sync/internal_api/attachments/on_disk_attachment_store.cc
+++ b/sync/internal_api/attachments/on_disk_attachment_store.cc
@@ -134,7 +134,7 @@ void OnDiskAttachmentStore::Read(
}
void OnDiskAttachmentStore::Write(
- AttachmentStore::AttachmentReferrer referrer,
+ AttachmentStore::Component component,
const AttachmentList& attachments,
const AttachmentStore::WriteCallback& callback) {
DCHECK(CalledOnValidThread());
@@ -153,11 +153,24 @@ void OnDiskAttachmentStore::Write(
PostCallback(base::Bind(callback, result_code));
}
-void OnDiskAttachmentStore::Drop(
- AttachmentStore::AttachmentReferrer referrer,
+void OnDiskAttachmentStore::SetReference(AttachmentStore::Component component,
+ const AttachmentIdList& ids) {
+ DCHECK(CalledOnValidThread());
+ DCHECK_EQ(AttachmentStore::SYNC, component);
+}
+
+void OnDiskAttachmentStore::DropReference(
+ AttachmentStore::Component component,
const AttachmentIdList& ids,
const AttachmentStore::DropCallback& callback) {
DCHECK(CalledOnValidThread());
+ if (component == AttachmentStore::SYNC) {
+ // TODO(pavely): There is no reference handling implementation yet. All
+ // calls to AddReferrer are ignored. Calls to Drop coming from sync should
+ // be ignored too.
+ PostCallback(base::Bind(callback, AttachmentStore::SUCCESS));
+ return;
+ }
AttachmentStore::Result result_code =
AttachmentStore::STORE_INITIALIZATION_FAILED;
if (db_) {
@@ -208,7 +221,7 @@ void OnDiskAttachmentStore::ReadMetadata(
}
void OnDiskAttachmentStore::ReadAllMetadata(
- AttachmentStore::AttachmentReferrer referrer,
+ AttachmentStore::Component component,
const AttachmentStore::ReadMetadataCallback& callback) {
DCHECK(CalledOnValidThread());
AttachmentStore::Result result_code =

Powered by Google App Engine
This is Rietveld 408576698