Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: sync/internal_api/attachments/in_memory_attachment_store.cc

Issue 1002263005: [Sync] Introduce AttachmentStoreForSync class (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/internal_api/attachments/in_memory_attachment_store.cc
diff --git a/sync/internal_api/attachments/in_memory_attachment_store.cc b/sync/internal_api/attachments/in_memory_attachment_store.cc
index ba2142663456b232623c52c0ef35fce0493bee26..b0fb84617da733e2686648534771801f71295426 100644
--- a/sync/internal_api/attachments/in_memory_attachment_store.cc
+++ b/sync/internal_api/attachments/in_memory_attachment_store.cc
@@ -66,7 +66,7 @@ void InMemoryAttachmentStore::Read(
}
void InMemoryAttachmentStore::Write(
- AttachmentStore::AttachmentReferrer referrer,
+ AttachmentStore::Component component,
const AttachmentList& attachments,
const AttachmentStore::WriteCallback& callback) {
DCHECK(CalledOnValidThread());
@@ -78,12 +78,25 @@ void InMemoryAttachmentStore::Write(
PostCallback(base::Bind(callback, AttachmentStore::SUCCESS));
}
-void InMemoryAttachmentStore::Drop(
- AttachmentStore::AttachmentReferrer referrer,
+void InMemoryAttachmentStore::SetReference(AttachmentStore::Component component,
+ const AttachmentIdList& ids) {
+ DCHECK(CalledOnValidThread());
+ DCHECK_EQ(AttachmentStore::SYNC, component);
+}
+
+void InMemoryAttachmentStore::DropReference(
+ AttachmentStore::Component component,
const AttachmentIdList& ids,
const AttachmentStore::DropCallback& callback) {
DCHECK(CalledOnValidThread());
AttachmentStore::Result result = AttachmentStore::SUCCESS;
+ if (component == AttachmentStore::SYNC) {
+ // TODO(pavely): There is no reference handling implementation yet. All
+ // calls to AddReferrer are ignored. Calls to Drop coming from sync should
+ // be ignored too.
+ PostCallback(base::Bind(callback, AttachmentStore::SUCCESS));
+ return;
+ }
AttachmentIdList::const_iterator ids_iter = ids.begin();
AttachmentIdList::const_iterator ids_end = ids.end();
for (; ids_iter != ids_end; ++ids_iter) {
@@ -117,7 +130,7 @@ void InMemoryAttachmentStore::ReadMetadata(
}
void InMemoryAttachmentStore::ReadAllMetadata(
- AttachmentStore::AttachmentReferrer referrer,
+ AttachmentStore::Component component,
const AttachmentStore::ReadMetadataCallback& callback) {
DCHECK(CalledOnValidThread());
AttachmentStore::Result result_code = AttachmentStore::SUCCESS;

Powered by Google App Engine
This is Rietveld 408576698