Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1002203002: Remove kind field from StackHandler. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove kind field from StackHandler. This makes the Isolate::Throw logic not depend on a prediction of whether an exception is caught or uncaught. Such a prediction is inherently undecidable because a finally block can decide between consuming or re-throwing an exception depending on arbitray control flow. There still is a conservative prediction mechanism in place that components like the debugger or tracing can use for reporting. With this change we can get rid of the StackHandler::kind field, a pre-requisite to do table-based lookups of exception handlers. R=yangguo@chromium.org Committed: https://crrev.com/96f79568a926966ebcf0685bf9adc947f4e1fbff Cr-Commit-Position: refs/heads/master@{#27210}

Patch Set 1 #

Patch Set 2 : Remove kind field. #

Patch Set 3 : Bring back debugger support. #

Patch Set 4 : Add TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -181 lines) Patch
M src/arm/macro-assembler-arm.cc View 1 1 chunk +3 lines, -6 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M src/debug.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M src/debug.cc View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M src/frames.h View 1 2 chunks +1 line, -14 lines 0 comments Download
M src/frames.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/frames-inl.h View 1 1 chunk +2 lines, -23 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M src/isolate.h View 1 2 5 chunks +11 lines, -10 lines 0 comments Download
M src/isolate.cc View 1 2 3 9 chunks +119 lines, -103 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-13 13:52:01 UTC) #2
Yang
On 2015/03/13 13:52:01, Michael Starzinger wrote: LGTM. Please keep an eye open for Blink breakages ...
5 years, 9 months ago (2015-03-13 14:16:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1002203002/60001
5 years, 9 months ago (2015-03-16 09:58:19 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-16 10:06:17 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/96f79568a926966ebcf0685bf9adc947f4e1fbff Cr-Commit-Position: refs/heads/master@{#27210}
5 years, 9 months ago (2015-03-16 10:06:33 UTC) #7
Michael Starzinger
5 years, 9 months ago (2015-03-16 11:40:49 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1009903002/ by mstarzinger@chromium.org.

The reason for reverting is: Layout test failure in
inspector/sources/debugger/debugger-pause-on-promise-rejection.html.

Powered by Google App Engine
This is Rietveld 408576698