Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/frames.cc

Issue 1002203002: Remove kind field from StackHandler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add TODO. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/frames.h ('k') | src/frames-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/frames.h" 5 #include "src/frames.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/v8.h" 9 #include "src/v8.h"
10 10
(...skipping 1320 matching lines...) Expand 10 before | Expand all | Expand 10 after
1331 } 1331 }
1332 1332
1333 accumulator->Add("}\n\n"); 1333 accumulator->Add("}\n\n");
1334 } 1334 }
1335 1335
1336 1336
1337 void EntryFrame::Iterate(ObjectVisitor* v) const { 1337 void EntryFrame::Iterate(ObjectVisitor* v) const {
1338 StackHandlerIterator it(this, top_handler()); 1338 StackHandlerIterator it(this, top_handler());
1339 DCHECK(!it.done()); 1339 DCHECK(!it.done());
1340 StackHandler* handler = it.handler(); 1340 StackHandler* handler = it.handler();
1341 DCHECK(handler->is_js_entry());
1342 handler->Iterate(v, LookupCode()); 1341 handler->Iterate(v, LookupCode());
1343 #ifdef DEBUG 1342 #ifdef DEBUG
1344 // Make sure that the entry frame does not contain more than one 1343 // Make sure that the entry frame does not contain more than one
1345 // stack handler. 1344 // stack handler.
1346 it.Advance(); 1345 it.Advance();
1347 DCHECK(it.done()); 1346 DCHECK(it.done());
1348 #endif 1347 #endif
1349 IteratePc(v, pc_address(), LookupCode()); 1348 IteratePc(v, pc_address(), LookupCode());
1350 } 1349 }
1351 1350
(...skipping 279 matching lines...) Expand 10 before | Expand all | Expand 10 after
1631 ZoneList<StackFrame*> list(10, zone); 1630 ZoneList<StackFrame*> list(10, zone);
1632 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) { 1631 for (StackFrameIterator it(isolate); !it.done(); it.Advance()) {
1633 StackFrame* frame = AllocateFrameCopy(it.frame(), zone); 1632 StackFrame* frame = AllocateFrameCopy(it.frame(), zone);
1634 list.Add(frame, zone); 1633 list.Add(frame, zone);
1635 } 1634 }
1636 return list.ToVector(); 1635 return list.ToVector();
1637 } 1636 }
1638 1637
1639 1638
1640 } } // namespace v8::internal 1639 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/frames.h ('k') | src/frames-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698