bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration

bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration

This is a preparation for using Maybe version of SetAccessor().
V8 is deprecating a version of SetAccessor() which takes
Accessor{Getter,Setter}Callback, and will only provide a version
of SetAccesor() which takes AccessorName{Getter,Setter}Callback.
Use AccessorName{Getter,Setter}Callback and v8::Name in bindings
so that we can replace old API in the follow-up CL.

BUG=462402
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191968

[bashi, 2015-03-13 08:55:38]

bashi@chromium.org changed reviewers:
+ haraken@chromium.org, yukishiino@chromium.org

[bashi, 2015-03-13 08:55:39]

PTAL?

Here is a Maybe version of SetAccessor()
https://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8.h&q=...

Instead of this change, we could ask the V8 team to add SetAccessor() variant
which takes Accessor{Getter,Setter}Callback. WDYT?

[haraken, 2015-03-13 09:02:25]

On 2015/03/13 08:55:39, bashi1 wrote:
> PTAL?
> 
> Here is a Maybe version of SetAccessor()
>
https://code.google.com/p/chromium/codesearch#chromium/src/v8/include/v8.h&q=...
> 
> Instead of this change, we could ask the V8 team to add SetAccessor() variant
> which takes Accessor{Getter,Setter}Callback. WDYT?

Worth asking.

[Yuki, 2015-03-13 09:05:06]

lgtm

https://codereview.chromium.org/1002163002/diff/1/Source/bindings/templates/i...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/1002163002/diff/1/Source/bindings/templates/i...
Source/bindings/templates/interface.cpp:479: ASSERT(name->IsString());
Please add a FIXME comment, or shall we wait for V8 team to provide
SetHiddenValue(Local<Name> key, Local<Value> value)?

[bashi, 2015-03-16 01:20:01]

bashi@chromium.org changed reviewers:
+ dcarney@chromium.org

[bashi, 2015-03-16 01:22:13]

dcanery@

What do you think about adding SetAccessor() which takes
Accessor{Getter,Setter}Callback and returns Maybe<boo>? Without having it, we
need this change.

[dcarney, 2015-03-16 20:10:27]

On 2015/03/16 01:22:13, bashi1 wrote:
> dcanery@
> 
> What do you think about adding SetAccessor() which takes
> Accessor{Getter,Setter}Callback and returns Maybe<boo>? Without having it, we
> need this change.

Accessor{Getter,Setter}Callbacks are deprecated.  You need to convert to
AccessorName{Getter,Setter}Callback

[dcarney, 2015-03-16 20:17:45]

https://codereview.chromium.org/1002163002/diff/1/Source/bindings/templates/i...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/1002163002/diff/1/Source/bindings/templates/i...
Source/bindings/templates/interface.cpp:479: ASSERT(name->IsString());
On 2015/03/13 09:05:06, Yuki wrote:
> Please add a FIXME comment, or shall we wait for V8 team to provide
> SetHiddenValue(Local<Name> key, Local<Value> value)?

As<v8::String> is already providing an ASSERT, so this is unnecessary

The HiddenValue api should go away and be replace by one which just uses
symbols, so I don't think transitioning the hidden apis makes much sense.

[haraken, 2015-03-16 23:19:40]

LGTM

[bashi, 2015-03-17 01:07:31]

https://codereview.chromium.org/1002163002/diff/1/Source/bindings/templates/i...
File Source/bindings/templates/interface.cpp (right):

https://codereview.chromium.org/1002163002/diff/1/Source/bindings/templates/i...
Source/bindings/templates/interface.cpp:479: ASSERT(name->IsString());
On 2015/03/16 20:17:44, dcarney wrote:
> On 2015/03/13 09:05:06, Yuki wrote:
> > Please add a FIXME comment, or shall we wait for V8 team to provide
> > SetHiddenValue(Local<Name> key, Local<Value> value)?
> 
> As<v8::String> is already providing an ASSERT, so this is unnecessary
> 
> The HiddenValue api should go away and be replace by one which just uses
> symbols, so I don't think transitioning the hidden apis makes much sense.

Removed.

[bashi, 2015-03-17 01:07:37]

The CQ bit was checked by bashi@chromium.org

[bashi, 2015-03-17 01:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
yukishiino@chromium.org
Link to the patchset: https://codereview.chromium.org/1002163002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-03-17 01:07:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1002163002/20001

[commit-bot: I haz the power, 2015-03-17 02:03:51]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191968