Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 1002163002: bindings: Use AccessorName{Getter,Setter}Callback in AttributeConfiguration (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp ('k') | Source/bindings/tests/results/core/V8TestObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index e38036830e1aa6593c7668e46aee1a10ae84f181..cf0b687d3f0b8283f46f00bb129dc42900f6c224 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -31,7 +31,7 @@ const WrapperTypeInfo& TestInterfaceNamedConstructor::s_wrapperTypeInfo = V8Test

namespace TestInterfaceNamedConstructorV8Internal {

template<class CallbackInfo>

-static void TestInterfaceNamedConstructorForceSetAttributeOnThis(v8::Local<v8::String> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

+static void TestInterfaceNamedConstructorForceSetAttributeOnThis(v8::Local<v8::Name> name, v8::Local<v8::Value> v8Value, const CallbackInfo& info)

{

ASSERT(info.This()->IsObject());

v8::Local<v8::Object>::Cast(info.This())->ForceSet(name, v8Value);

@@ -43,7 +43,7 @@ static void testNamedConstructorConstructorAttributeAttributeSetter(v8::Local<v8

TestInterfaceNamedConstructorForceSetAttributeOnThis(propertyName, v8Value, info);

}

-static void testNamedConstructorConstructorAttributeAttributeSetterCallback(v8::Local<v8::String>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

+static void testNamedConstructorConstructorAttributeAttributeSetterCallback(v8::Local<v8::Name>, v8::Local<v8::Value> v8Value, const v8::PropertyCallbackInfo<void>& info)

{

TRACE_EVENT_SET_SAMPLING_STATE("blink", "DOMSetter");

TestInterfaceNamedConstructorV8Internal::testNamedConstructorConstructorAttributeAttributeSetter(v8Value, info);