Allow obj-c import statements to be as long as necessary.

Allow obj-c import statements to be as long as necessary.

I've unified the checks for language specific exceptions to line length. There is a behavior change where cpp compiler directives no longer have a maximum line length (previously they were restricted to 150% of max line length). This change was made to match the behavior for java files.

BUG=NONE

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=238268

[M-A Ruel, 2013-12-02 21:24:26]

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:325: MACROS = ('#define', '#include', '#import',
'#pragma', '#if', '#endif')
Why not add it there instead?

[erikchen2, 2013-12-02 21:28:41]

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:325: MACROS = ('#define', '#include', '#import',
'#pragma', '#if', '#endif')
On 2013/12/02 21:24:27, M-A Ruel wrote:
> Why not add it there instead?

because those are the C++ specific compiler directives, whereas #import is a
obj-c specific compiler directive.

Would you like me to add #import to the MACROS tuple, and just get rid of all of
the specific obj-c checks?

[M-A Ruel, 2013-12-02 21:52:27]

or you could refactor for java/C/Obj-c dict.

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:325: MACROS = ('#define', '#include', '#import',
'#pragma', '#if', '#endif')
On 2013/12/02 21:28:41, erikchen wrote:
> On 2013/12/02 21:24:27, M-A Ruel wrote:
> > Why not add it there instead?
> 
> because those are the C++ specific compiler directives, whereas #import is a
> obj-c specific compiler directive.
> 
> Would you like me to add #import to the MACROS tuple, and just get rid of all
of
> the specific obj-c checks?

As the comment above says, these prefixes are checked independent on the source
language.

[erikchen2, 2013-12-02 22:37:13]

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/1/presubmit_canned_checks.py#n...
presubmit_canned_checks.py:325: MACROS = ('#define', '#include', '#import',
'#pragma', '#if', '#endif')
On 2013/12/02 21:52:28, M-A Ruel wrote:
> On 2013/12/02 21:28:41, erikchen wrote:
> > On 2013/12/02 21:24:27, M-A Ruel wrote:
> > > Why not add it there instead?
> > 
> > because those are the C++ specific compiler directives, whereas #import is a
> > obj-c specific compiler directive.
> > 
> > Would you like me to add #import to the MACROS tuple, and just get rid of
all
> of
> > the specific obj-c checks?
> 
> As the comment above says, these prefixes are checked independent on the
source
> language.

I've unified the code for java, cpp and obj-c exceptions to max line length.
There is a behavior change where cpp compiler directives no longer have a max
line length (previously it was 150% of max line length), which was made to match
the behavior for java compiler directives.

[M-A Ruel, 2013-12-02 23:56:26]

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:329: JAVA_FILE_EXTS = ('java')
This was not doing what you thought it was doing. You want:
JAVA_FILE_EXTS = ('java',)

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:330: JAVA_EXCPTS = ('package ', 'import ')
sort

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:333: '#endif', '#import')
duplicate of #import

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:335: LANGUAGE_EXCEPTIONS = [
I'd used a list of tuple instead.
LANGUAGE_EXCEPTIONS = [
  (CPP_FILE_EXTS, CPP_EXCEPTIONS),
  (JAVA_FILE_EXTS, JAVA_EXCEPTIONS),
  (OBJC_FILE_EXTS, OBJ_EXCEPTIONS),
]

but I don't mind much.

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:343: for language in LANGUAGE_EXCEPTIONS:
if any(
    file_extensions in ext and line.startswith(exceptions)
    for ext, exceptions in LANGUAGE_EXCEPTIONS):
  return True

[erikchen2, 2013-12-03 00:20:08]

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:329: JAVA_FILE_EXTS = ('java')
On 2013/12/02 23:56:27, M-A Ruel wrote:
> This was not doing what you thought it was doing. You want:
> JAVA_FILE_EXTS = ('java',)

ack, thanks

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:330: JAVA_EXCPTS = ('package ', 'import ')
On 2013/12/02 23:56:27, M-A Ruel wrote:
> sort

Done.

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:333: '#endif', '#import')
On 2013/12/02 23:56:27, M-A Ruel wrote:
> duplicate of #import

Done.

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:335: LANGUAGE_EXCEPTIONS = [
On 2013/12/02 23:56:27, M-A Ruel wrote:
> I'd used a list of tuple instead.
> LANGUAGE_EXCEPTIONS = [
>   (CPP_FILE_EXTS, CPP_EXCEPTIONS),
>   (JAVA_FILE_EXTS, JAVA_EXCEPTIONS),
>   (OBJC_FILE_EXTS, OBJ_EXCEPTIONS),
> ]
> 
> but I don't mind much.

Done.

https://codereview.chromium.org/100163002/diff/20001/presubmit_canned_checks....
presubmit_canned_checks.py:343: for language in LANGUAGE_EXCEPTIONS:
On 2013/12/02 23:56:27, M-A Ruel wrote:
> if any(
>     file_extensions in ext and line.startswith(exceptions)
>     for ext, exceptions in LANGUAGE_EXCEPTIONS):
>   return True

Done.

[M-A Ruel, 2013-12-03 01:40:55]

lgtm

https://codereview.chromium.org/100163002/diff/40001/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/40001/presubmit_canned_checks....
presubmit_canned_checks.py:329: CPP_EXCEPTIONS = ('#define', '#include',
'#pragma', '#if', '#endif')
sort

https://codereview.chromium.org/100163002/diff/40001/presubmit_canned_checks....
presubmit_canned_checks.py:333: OBJC_EXCEPTIONS = ('#define', '#include',
'#import', '#pragma', '#if',
sort

[erikchen2, 2013-12-03 01:47:43]

https://codereview.chromium.org/100163002/diff/40001/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

https://codereview.chromium.org/100163002/diff/40001/presubmit_canned_checks....
presubmit_canned_checks.py:329: CPP_EXCEPTIONS = ('#define', '#include',
'#pragma', '#if', '#endif')
On 2013/12/03 01:40:56, M-A Ruel wrote:
> sort

Done.

https://codereview.chromium.org/100163002/diff/40001/presubmit_canned_checks....
presubmit_canned_checks.py:333: OBJC_EXCEPTIONS = ('#define', '#include',
'#import', '#pragma', '#if',
On 2013/12/03 01:40:56, M-A Ruel wrote:
> sort

Done.

[commit-bot: I haz the power, 2013-12-03 02:02:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erikchen@google.com/100163002/80001

[commit-bot: I haz the power, 2013-12-03 02:04:21]

Change committed as 238268