Allow obj-c import statements to be as long as necessary.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 303 matching lines @@
 def CheckLongLines(input_api, output_api, maxlen, source_file_filter=None):
   """Checks that there aren't any lines longer than maxlen characters in any of
   the text files to be submitted.
   """
   maxlens = {
       'java': 100,
       # This is specifically for Android's handwritten makefiles (Android.mk).
       'mk': 200,
       '': maxlen,
   }
-  # Note: these are C++ specific but processed on all languages. :(
-  MACROS = ('#define', '#include', '#import', '#pragma', '#if', '#endif')
 
-  # Special java statements.
-  SPECIAL_JAVA_STARTS = ('package ', 'import ')
+  # Language specific exceptions to max line length.
+  # '.h' files count as obj-c, since OBJC_EXCPTS are a superset of CPP_EXCPTS.
+  CPP_FILE_EXTS = ('c', 'cc')
+  CPP_EXCPTS = ('#define', '#include', '#import', '#pragma', '#if', '#endif')
+  JAVA_FILE_EXTS = ('java')

[M-A Ruel, 2013/12/02 23:56:27]

This was not doing what you thought it was doing. You want:
JAVA_FILE_EXTS = ('java',)

[erikchen2, 2013/12/03 00:20:09]

ack, thanks

+  JAVA_EXCPTS = ('package ', 'import ')

[M-A Ruel, 2013/12/02 23:56:27]

sort

[erikchen2, 2013/12/03 00:20:09]

Done.

+  OBJC_FILE_EXTS = ('h', 'm', 'mm')
+  OBJC_EXCPTS = ('#define', '#include', '#import', '#pragma', '#if',
+                 '#endif', '#import')

[M-A Ruel, 2013/12/02 23:56:27]

duplicate of #import

[erikchen2, 2013/12/03 00:20:09]

Done.

+
+  LANGUAGE_EXCEPTIONS = [

[M-A Ruel, 2013/12/02 23:56:27]

I'd used a list of tuple instead.
LANGUAGE_EXCEPTIONS = [
  (CPP_FILE_EXTS, CPP_EXCEPTIONS),
  (JAVA_FILE_EXTS, JAVA_EXCEPTIONS),
  (OBJC_FILE_EXTS, OBJ_EXCEPTIONS),
]

but I don't mind much.

[erikchen2, 2013/12/03 00:20:09]

Done.

+    {'extensions' : CPP_FILE_EXTS, 'excpts' : CPP_EXCPTS},
+    {'extensions' : JAVA_FILE_EXTS, 'excpts' : JAVA_EXCPTS},
+    {'extensions' : OBJC_FILE_EXTS, 'excpts' : OBJC_EXCPTS},
+  ]
 
   def no_long_lines(file_extension, line):
-    # Allow special java statements to be as long as necessary.
-    if file_extension == 'java' and line.startswith(SPECIAL_JAVA_STARTS):
-      return True
+    # Check for language specific exceptions.
+    for language in LANGUAGE_EXCEPTIONS:

[M-A Ruel, 2013/12/02 23:56:27]

if any(
    file_extensions in ext and line.startswith(exceptions)
    for ext, exceptions in LANGUAGE_EXCEPTIONS):
  return True

[erikchen2, 2013/12/03 00:20:09]

Done.

+      if (file_extension in language['extensions'] and
+          line.startswith(language['excpts'])):
+        return True
 
     file_maxlen = maxlens.get(file_extension, maxlens[''])
     # Stupidly long symbols that needs to be worked around if takes 66% of line.
     long_symbol = file_maxlen * 2 / 3
     # Hard line length limit at 50% more.
     extra_maxlen = file_maxlen * 3 / 2
 
     line_len = len(line)
     if line_len <= file_maxlen:
       return True
 
     if line_len > extra_maxlen:
       return False
 
     return (
-        line.startswith(MACROS) or
         any((url in line) for url in ('http://', 'https://')) or
         input_api.re.match(
           r'.*[A-Za-z][A-Za-z_0-9]{%d,}.*' % long_symbol, line))
 
   def format_error(filename, line_num, line):
     return '%s, line %s, %s chars' % (filename, line_num, len(line))
 
   errors = _FindNewViolationsOfRule(no_long_lines, input_api,
                                     source_file_filter,
                                     error_formatter=format_error)
@@ skipping 663 matching lines @@
     snapshot("checking description")
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
         input_api, output_api))
     snapshot("checking do not submit in files")
     results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
         input_api, output_api))
   snapshot("done")
   return results