Allow obj-c import statements to be as long as necessary.

presubmit_canned_checks.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic presubmit checks that can be reused by other presubmit checks."""
 
 import os as _os
 _HERE = _os.path.dirname(_os.path.abspath(__file__))
 
 
@@ skipping 304 matching lines @@
   """Checks that there aren't any lines longer than maxlen characters in any of
   the text files to be submitted.
   """
   maxlens = {
       'java': 100,
       # This is specifically for Android's handwritten makefiles (Android.mk).
       'mk': 200,
       '': maxlen,
   }
   # Note: these are C++ specific but processed on all languages. :(
   MACROS = ('#define', '#include', '#import', '#pragma', '#if', '#endif')

[M-A Ruel, 2013/12/02 21:24:27]

Why not add it there instead?

[erikchen2, 2013/12/02 21:28:41]

because those are the C++ specific compiler directives, whereas #import is a
obj-c specific compiler directive.

Would you like me to add #import to the MACROS tuple, and just get rid of all of
the specific obj-c checks?

[M-A Ruel, 2013/12/02 21:52:28]

As the comment above says, these prefixes are checked independent on the source
language.

[erikchen2, 2013/12/02 22:37:13]

I've unified the code for java, cpp and obj-c exceptions to max line length.
There is a behavior change where cpp compiler directives no longer have a max
line length (previously it was 150% of max line length), which was made to match
the behavior for java compiler directives.

 
   # Special java statements.
   SPECIAL_JAVA_STARTS = ('package ', 'import ')
 
+  # Special obj-c statements.
+  OBJC_FILE_EXTENSIONS = ('h', 'm', 'mm')
+  SPECIAL_OBJC_STARTS = ('#import')
+
   def no_long_lines(file_extension, line):
     # Allow special java statements to be as long as necessary.
     if file_extension == 'java' and line.startswith(SPECIAL_JAVA_STARTS):
       return True
 
+    # Allow special obj-c statements to be as long as necessary.
+    if file_extension in OBJC_FILE_EXTENSIONS and\
+        line.startswith(SPECIAL_OBJC_STARTS):
+      return True
+
     file_maxlen = maxlens.get(file_extension, maxlens[''])
     # Stupidly long symbols that needs to be worked around if takes 66% of line.
     long_symbol = file_maxlen * 2 / 3
     # Hard line length limit at 50% more.
     extra_maxlen = file_maxlen * 3 / 2
 
     line_len = len(line)
     if line_len <= file_maxlen:
       return True
 
@@ skipping 678 matching lines @@
     snapshot("checking description")
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(input_api.canned_checks.CheckDoNotSubmitInDescription(
         input_api, output_api))
     snapshot("checking do not submit in files")
     results.extend(input_api.canned_checks.CheckDoNotSubmitInFiles(
         input_api, output_api))
   snapshot("done")
   return results