Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 1001393002: Telemetry: Don't expose ListInspectableContexts from DevtoolsClientBackend. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, yurys, aandrey+blink_chromium.org, telemetry-reviews_chromium.org, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@telemetry_dont_expose_devtools_http
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Don't expose ListInspectableContexts from DevtoolsClientBackend. This is a task left over from Issue 423954. I made the method private, and added public methods to give InspectorBackend the same functionality. I removed the method ListInspectableContexts from IosBrowserBackend and ChromeBrowserBackend, since its never used. BUG=423954, 460625 Committed: https://crrev.com/dc302039d5febcc8f97e9848ab2be4f93ed75f63 Cr-Commit-Position: refs/heads/master@{#321014}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -27 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py View 2 chunks +22 lines, -5 lines 1 comment Download
M tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py View 2 chunks +12 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
erikchen
dtu: Please review. https://codereview.chromium.org/1001393002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py File tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py (right): https://codereview.chromium.org/1001393002/diff/1/tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py#newcode147 tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py:147: def GetUrl(self, tab_id): It's unexpected for ...
5 years, 9 months ago (2015-03-13 18:20:26 UTC) #2
dtu
lgtm
5 years, 9 months ago (2015-03-17 21:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1001393002/1
5 years, 9 months ago (2015-03-17 21:42:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 23:57:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 23:57:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc302039d5febcc8f97e9848ab2be4f93ed75f63
Cr-Commit-Position: refs/heads/master@{#321014}

Powered by Google App Engine
This is Rietveld 408576698