Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Unified Diff: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py

Issue 1001393002: Telemetry: Don't expose ListInspectableContexts from DevtoolsClientBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_dont_expose_devtools_http
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
diff --git a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
index 19bf739821cce567ec6d56577fac030169d97c0d..52b5c7dc545ddca2c40c55589de62f7f651ce073 100644
--- a/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
+++ b/tools/telemetry/telemetry/core/backends/chrome_inspector/inspector_backend.py
@@ -92,10 +92,12 @@ class InspectorBackend(object):
@property
def url(self):
- for c in self._devtools_client.ListInspectableContexts():
- if c['id'] == self._context['id']:
- return c['url']
- return None
+ """Returns the URL of the tab, as reported by devtools.
+
+ Raises:
+ devtools_http.DevToolsClientConnectionError
+ """
+ return self._devtools_client.GetUrl(self.id)
@property
def id(self):
@@ -106,8 +108,12 @@ class InspectorBackend(object):
return self._context['webSocketDebuggerUrl']
def IsInspectable(self):
- contexts = self._devtools_client.ListInspectableContexts()
- return self._context['id'] in [c['id'] for c in contexts]
+ """Whether the tab is inspectable, as reported by devtools.
+
+ Raises:
+ devtools_http.DevToolsClientConnectionError
+ """
+ return self._devtools_client.IsInspectable(self.id)
# Public methods implemented in JavaScript.

Powered by Google App Engine
This is Rietveld 408576698