tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py - Issue 1001393002: Telemetry: Don't expose ListInspectableContexts from DevtoolsClientBackend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

Issue 1001393002: Telemetry: Don't expose ListInspectableContexts from DevtoolsClientBackend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@telemetry_dont_expose_devtools_http

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | tools/telemetry/telemetry/core/backends/chrome/ios_browser_backend.py » ('j') | tools/telemetry/telemetry/core/backends/chrome_inspector/devtools_client_backend.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

index 31f89b76392753c9de641abb23aba2b3ee629f0a..4a4408bedef115d9989d98dfeb8b87a62eb82477 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/chrome_browser_backend.py

@@ -246,14 +246,6 @@ class ChromeBrowserBackend(browser_backend.BrowserBackend):

return False

return True

- def ListInspectableContexts(self):

- try:

- return self._devtools_client.ListInspectableContexts()

- except devtools_http.DevToolsClientConnectionError as e:

- if not self.IsBrowserRunning():

- raise exceptions.BrowserGoneException(self.browser, e)

- raise exceptions.BrowserConnectionGoneException(self.browser, e)

@property

def browser_directory(self):

raise NotImplementedError()