Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9409)

Unified Diff: build/java_apk.gypi

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/java_apk.gypi
diff --git a/build/java_apk.gypi b/build/java_apk.gypi
index c5e7ae3f110ad6ccac6b073daeee993aefc0ec3f..12d48f4b80b62d88d09e7ff7f3a4fb58c52b232b 100644
--- a/build/java_apk.gypi
+++ b/build/java_apk.gypi
@@ -103,6 +103,7 @@
'lint_result': '<(intermediate_dir)/lint_result.xml',
'lint_config': '<(intermediate_dir)/lint_config.xml',
'never_lint%': 0,
+ 'findbugs_stamp': '<(intermediate_dir)/findbugs.stamp',
'java_in_dir_suffix%': '/src',
'instr_stamp': '<(intermediate_dir)/instr.stamp',
'jar_stamp': '<(intermediate_dir)/jar.stamp',
@@ -705,6 +706,32 @@
'includes': [ 'android/lint_action.gypi' ],
},
{
+ 'action_name': 'findbugs_<(_target_name)',
jbudorick 2015/03/13 13:12:20 moved this into a condition like java.gypi
+ 'message': 'Running findbugs on <(_target_name)',
+ 'variables': {
+ 'auxclasspath': [
+ '>@(input_jars_paths)',
+ '<(android_sdk_jar)',
+ ],
+ },
+ 'inputs': [
+ '<(DEPTH)/build/android/findbugs_diff.py',
+ '<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',
+ '<(DEPTH)/build/android/pylib/utils/findbugs.py',
+ '<(jar_path)',
+ '<(compile_stamp)',
+ ],
+ 'outputs': [
+ '<(findbugs_stamp)',
+ ],
+ 'action': [
+ 'python', '<(DEPTH)/build/android/findbugs_diff.py',
+ '--auxclasspath-gyp', '>(auxclasspath)',
+ '--stamp', '<(findbugs_stamp)',
+ '<(jar_path)',
+ ],
+ },
+ {
'action_name': 'obfuscate_<(_target_name)',
'message': 'Obfuscating <(_target_name)',
'variables': {
@@ -799,6 +826,10 @@
'output_path': '<(dex_path)',
'proguard_enabled_input_path': '<(obfuscated_jar_path)',
},
+ 'inputs': [
jbudorick 2015/03/13 13:12:20 removed this one too
+ '<(findbugs_stamp)',
+ '<(lint_stamp)',
+ ],
'target_conditions': [
['emma_instrument != 0', {
'variables': {

Powered by Google App Engine
This is Rietveld 408576698