[Android] Incorporate findbugs into android builds.

build/java.gypi

Index: build/java.gypi
diff --git a/build/java.gypi b/build/java.gypi
index 061dff2ad7bdaef2228f2d7cff751ed77bf46b49..82bfab5503eb545da6c5257d3df226c143c2de63 100644
--- a/build/java.gypi
+++ b/build/java.gypi
@@ -77,6 +77,8 @@
     'lint_result': '<(intermediate_dir)/lint_result.xml',
     'lint_config': '<(intermediate_dir)/lint_config.xml',
     'never_lint%': 0,
+    'findbugs_stamp': '<(intermediate_dir)/findbugs.stamp',
+    'run_findbugs%': 1,
     'proguard_config%': '',
     'proguard_preprocess%': '0',
     'variables': {
@@ -217,6 +219,30 @@
         },
       ],
     }],
+    ['run_findbugs == 1', {
+      'actions': [
+        {
+          'action_name': 'findbugs_<(_target_name)',
+          'message': 'Running findbugs on <(_target_name)',
+          'inputs': [
+            '<(DEPTH)/build/android/findbugs_diff.py',
+            '<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',
+            '<(DEPTH)/build/android/pylib/utils/findbugs.py',

[cjhopman, 2015/03/12 19:22:43]

This should also include >@(input_jars_paths) i think

[jbudorick, 2015/03/13 13:12:20]

yep, it should. done.

+            '<(jar_final_path)',
+            '<(compile_stamp)',
+          ],
+          'outputs': [
+            '<(findbugs_stamp)',
+          ],
+          'action': [
+            'python', '<(DEPTH)/build/android/findbugs_diff.py',
+            '--auxclasspath-gyp', '>(input_jars_paths)',
+            '--stamp', '<(findbugs_stamp)',
+            '<(jar_final_path)',
+          ],
+        },
+      ],
+    }],
   ],
   'actions': [
     {
@@ -314,6 +340,10 @@
         'dex_input_paths': [ '<(jar_final_path)' ],
         'output_path': '<(dex_path)',
       },
+      'inputs': [

[cjhopman, 2015/03/12 19:22:43]

Is this required? I believe that gyp will create a stamp build target that
depends on all of the internal actions finishing (so that anytime this target is
built, lint/findbugs will run if necessary). I could be wrong about that,
though.

[jbudorick, 2015/03/13 13:12:19]

No, it isn't. In fact, builds locally seem to be going faster without it...
maybe introducing this was why my builds were so slow?

+        '<(findbugs_stamp)',
+        '<(lint_stamp)',
+      ],
       'includes': [ 'android/dex_action.gypi' ],
     },
   ],