[Android] Incorporate findbugs into android builds.

build/java_apk.gypi

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file is meant to be included into a target to provide a rule
 # to build Android APKs in a consistent manner.
 #
 # To use this, create a gyp target with the following form:
 # {
 #   'target_name': 'my_package_apk',
@@ skipping 85 matching lines @@
     'native_libraries_java_file': '<(native_libraries_java_dir)/NativeLibraries.java',
     'native_libraries_java_stamp': '<(intermediate_dir)/native_libraries_java.stamp',
     'native_libraries_template_data_dir': '<(intermediate_dir)/native_libraries/',
     'native_libraries_template_data_file': '<(native_libraries_template_data_dir)/native_libraries_array.h',
     'native_libraries_template_version_file': '<(native_libraries_template_data_dir)/native_libraries_version.h',
     'compile_stamp': '<(intermediate_dir)/compile.stamp',
     'lint_stamp': '<(intermediate_dir)/lint.stamp',
     'lint_result': '<(intermediate_dir)/lint_result.xml',
     'lint_config': '<(intermediate_dir)/lint_config.xml',
     'never_lint%': 0,
+    'findbugs_stamp': '<(intermediate_dir)/findbugs.stamp',
     'java_in_dir_suffix%': '/src',
     'instr_stamp': '<(intermediate_dir)/instr.stamp',
     'jar_stamp': '<(intermediate_dir)/jar.stamp',
     'obfuscate_stamp': '<(intermediate_dir)/obfuscate.stamp',
     'pack_arm_relocations_stamp': '<(intermediate_dir)/pack_arm_relocations.stamp',
     'strip_stamp': '<(intermediate_dir)/strip.stamp',
     'stripped_libraries_dir': '<(intermediate_dir)/stripped_libraries',
     'strip_additional_stamp': '<(intermediate_dir)/strip_additional.stamp',
     'version_stamp': '<(intermediate_dir)/version.stamp',
     'javac_includes': [],
@@ skipping 582 matching lines @@
         'stamp_path': '<(lint_stamp)',
         'result_path': '<(lint_result)',
         'config_path': '<(lint_config)',
       },
       'outputs': [
         '<(lint_stamp)',
       ],
       'includes': [ 'android/lint_action.gypi' ],
     },
     {
+      'action_name': 'findbugs_<(_target_name)',

[jbudorick, 2015/03/13 13:12:20]

moved this into a condition like java.gypi

+      'message': 'Running findbugs on <(_target_name)',
+      'variables': {
+        'auxclasspath': [
+          '>@(input_jars_paths)',
+          '<(android_sdk_jar)',
+        ],
+      },
+      'inputs': [
+        '<(DEPTH)/build/android/findbugs_diff.py',
+        '<(DEPTH)/build/android/findbugs_filter/findbugs_exclude.xml',
+        '<(DEPTH)/build/android/pylib/utils/findbugs.py',
+        '<(jar_path)',
+        '<(compile_stamp)',
+      ],
+      'outputs': [
+        '<(findbugs_stamp)',
+      ],
+      'action': [
+        'python', '<(DEPTH)/build/android/findbugs_diff.py',
+        '--auxclasspath-gyp', '>(auxclasspath)',
+        '--stamp', '<(findbugs_stamp)',
+        '<(jar_path)',
+      ],
+    },
+    {
       'action_name': 'obfuscate_<(_target_name)',
       'message': 'Obfuscating <(_target_name)',
       'variables': {
         'additional_obfuscate_options': [],
         'additional_obfuscate_input_paths': [],
         'proguard_out_dir': '<(intermediate_dir)/proguard',
         'proguard_input_jar_paths': [
           '>@(input_jars_paths)',
           '<(jar_path)',
         ],
@@ skipping 74 matching lines @@
     {
       'action_name': 'dex_<(_target_name)',
       'variables': {
         'dex_input_paths': [
           '>@(library_dexed_jars_paths)',
           '<(jar_path)',
         ],
         'output_path': '<(dex_path)',
         'proguard_enabled_input_path': '<(obfuscated_jar_path)',
       },
+      'inputs': [

[jbudorick, 2015/03/13 13:12:20]

removed this one too

+        '<(findbugs_stamp)',
+        '<(lint_stamp)',
+      ],
       'target_conditions': [
         ['emma_instrument != 0', {
           'variables': {
             'dex_no_locals': 1,
             'dex_input_paths': [
               '<(emma_device_jar)'
             ],
           },
         }],
         ['is_test_apk == 1 and tested_apk_dex_path != "/"', {
@@ skipping 114 matching lines @@
         '-DEMMA_INSTRUMENT=<(emma_instrument)',
         '-DEMMA_DEVICE_JAR=<(emma_device_jar)',
 
         '-Dbasedir=.',
         '-buildfile',
         '<(DEPTH)/build/android/ant/apk-package.xml',
       ]
     },
   ],
 }