Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
index 230ff12efe2a476730a1341f59f320f901c91745..ce26fb2482675e4ca3ee4bf08140b719c4479cc7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java
@@ -21,6 +21,7 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.CalledByNative;
import org.chromium.base.ThreadUtils;
import org.chromium.base.TraceEvent;
+import org.chromium.base.annotations.SuppressFBWarnings;
import org.chromium.base.library_loader.LibraryLoader;
import org.chromium.base.library_loader.LibraryProcessType;
import org.chromium.base.library_loader.LoaderErrors;
@@ -241,12 +242,14 @@ public abstract class ChromiumApplication extends ContentApplication {
.setCancelable(true)
.setPositiveButton(getResources().getString(android.R.string.ok),
new DialogInterface.OnClickListener() {
+ @SuppressFBWarnings("DM_EXIT")
@Override
public void onClick(DialogInterface dialog, int which) {
System.exit(-1);
}
})
.setOnCancelListener(new DialogInterface.OnCancelListener() {
+ @SuppressFBWarnings("DM_EXIT")
@Override
public void onCancel(DialogInterface dialog) {
System.exit(-1);
« no previous file with comments | « build/protoc_java.gypi ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698