Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser; 5 package org.chromium.chrome.browser;
6 6
7 import android.app.Activity; 7 import android.app.Activity;
8 import android.app.AlertDialog; 8 import android.app.AlertDialog;
9 import android.app.Dialog; 9 import android.app.Dialog;
10 import android.content.Context; 10 import android.content.Context;
11 import android.content.DialogInterface; 11 import android.content.DialogInterface;
12 import android.content.Intent; 12 import android.content.Intent;
13 import android.os.Build; 13 import android.os.Build;
14 import android.os.Bundle; 14 import android.os.Bundle;
15 import android.support.v4.app.DialogFragment; 15 import android.support.v4.app.DialogFragment;
16 import android.support.v4.app.FragmentActivity; 16 import android.support.v4.app.FragmentActivity;
17 import android.util.Log; 17 import android.util.Log;
18 18
19 import org.chromium.base.ActivityState; 19 import org.chromium.base.ActivityState;
20 import org.chromium.base.ApplicationStatus; 20 import org.chromium.base.ApplicationStatus;
21 import org.chromium.base.CalledByNative; 21 import org.chromium.base.CalledByNative;
22 import org.chromium.base.ThreadUtils; 22 import org.chromium.base.ThreadUtils;
23 import org.chromium.base.TraceEvent; 23 import org.chromium.base.TraceEvent;
24 import org.chromium.base.annotations.SuppressFBWarnings;
24 import org.chromium.base.library_loader.LibraryLoader; 25 import org.chromium.base.library_loader.LibraryLoader;
25 import org.chromium.base.library_loader.LibraryProcessType; 26 import org.chromium.base.library_loader.LibraryProcessType;
26 import org.chromium.base.library_loader.LoaderErrors; 27 import org.chromium.base.library_loader.LoaderErrors;
27 import org.chromium.base.library_loader.ProcessInitException; 28 import org.chromium.base.library_loader.ProcessInitException;
28 import org.chromium.chrome.R; 29 import org.chromium.chrome.R;
29 import org.chromium.chrome.browser.child_accounts.ChildAccountService; 30 import org.chromium.chrome.browser.child_accounts.ChildAccountService;
30 import org.chromium.chrome.browser.firstrun.FirstRunActivity; 31 import org.chromium.chrome.browser.firstrun.FirstRunActivity;
31 import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings; 32 import org.chromium.chrome.browser.net.spdyproxy.DataReductionProxySettings;
32 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomiza tions; 33 import org.chromium.chrome.browser.partnercustomizations.PartnerBrowserCustomiza tions;
33 import org.chromium.chrome.browser.preferences.LocationSettings; 34 import org.chromium.chrome.browser.preferences.LocationSettings;
(...skipping 200 matching lines...) Expand 10 before | Expand all | Expand 10 after
234 235
235 DialogFragment dialog = new DialogFragment() { 236 DialogFragment dialog = new DialogFragment() {
236 @Override 237 @Override
237 public Dialog onCreateDialog(Bundle savedInstanceState) { 238 public Dialog onCreateDialog(Bundle savedInstanceState) {
238 AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(getA ctivity()); 239 AlertDialog.Builder dialogBuilder = new AlertDialog.Builder(getA ctivity());
239 dialogBuilder 240 dialogBuilder
240 .setMessage(message) 241 .setMessage(message)
241 .setCancelable(true) 242 .setCancelable(true)
242 .setPositiveButton(getResources().getString(android.R.st ring.ok), 243 .setPositiveButton(getResources().getString(android.R.st ring.ok),
243 new DialogInterface.OnClickListener() { 244 new DialogInterface.OnClickListener() {
245 @SuppressFBWarnings("DM_EXIT")
244 @Override 246 @Override
245 public void onClick(DialogInterface dialog, int which) { 247 public void onClick(DialogInterface dialog, int which) {
246 System.exit(-1); 248 System.exit(-1);
247 } 249 }
248 }) 250 })
249 .setOnCancelListener(new DialogInterface.OnCancelListene r() { 251 .setOnCancelListener(new DialogInterface.OnCancelListene r() {
252 @SuppressFBWarnings("DM_EXIT")
250 @Override 253 @Override
251 public void onCancel(DialogInterface dialog) { 254 public void onCancel(DialogInterface dialog) {
252 System.exit(-1); 255 System.exit(-1);
253 } 256 }
254 }); 257 });
255 return dialogBuilder.create(); 258 return dialogBuilder.create();
256 } 259 }
257 }; 260 };
258 dialog.show( 261 dialog.show(
259 ((FragmentActivity) activity).getSupportFragmentManager(), "Inva lidStartupDialog"); 262 ((FragmentActivity) activity).getSupportFragmentManager(), "Inva lidStartupDialog");
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 TraceEvent.begin("ChromiumApplication.flushPersistentData"); 329 TraceEvent.begin("ChromiumApplication.flushPersistentData");
327 nativeFlushPersistentData(); 330 nativeFlushPersistentData();
328 } finally { 331 } finally {
329 TraceEvent.end("ChromiumApplication.flushPersistentData"); 332 TraceEvent.end("ChromiumApplication.flushPersistentData");
330 } 333 }
331 } 334 }
332 335
333 private static native String nativeGetBrowserUserAgent(); 336 private static native String nativeGetBrowserUserAgent();
334 private static native void nativeFlushPersistentData(); 337 private static native void nativeFlushPersistentData();
335 } 338 }
OLDNEW
« no previous file with comments | « build/protoc_java.gypi ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698