chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java - Issue 1000793002: [Android] Incorporate findbugs into android builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java

Issue 1000793002: [Android] Incorporate findbugs into android builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address cjhopman's comment + rebase Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromiumApplication.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java

index 52616f8baba7c7c20799df493cd572114c8488f5..d1f7cc2091a9c94ca6b09a598e23507a7a3b11b4 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/appmenu/AppMenuTest.java

@@ -14,6 +14,7 @@ import android.widget.ListPopupWindow;

import android.widget.ListView;

import org.chromium.base.ThreadUtils;

+import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

import org.chromium.chrome.shell.ChromeShellActivity;

@@ -33,6 +34,7 @@ public class AppMenuTest extends ChromeShellTestBase {

/**

* AppMenuHandler that will be used to intercept item selections for testing.

+ @SuppressFBWarnings("URF_UNREAD_FIELD")

public static class AppMenuHandlerForTest extends AppMenuHandler {

int mLastSelectedItemId = -1;