Added GLES3 Capabilities to the Command Buffer

Added GLES3 Capabilities to the Command Buffer

BUG=429053
Committed: https://crrev.com/54ecef179cb661240c978dded621a910ea2bda1c
Cr-Commit-Position: refs/heads/master@{#321263}

[bajones, 2015-03-10 22:46:19]

bajones@chromium.org changed reviewers:
+ piman@chromium.org, zmo@chromium.org

[bajones, 2015-03-10 22:46:19]

PTAL.

[Zhenyao Mo, 2015-03-10 22:53:07]

LGTM

[piman, 2015-03-10 22:54:46]

https://codereview.chromium.org/1000483002/diff/20001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_state_impl_autogen.h (right):

https://codereview.chromium.org/1000483002/diff/20001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state_impl_autogen.h:191:
enable_flags.cached_rasterizer_discard);
We shouldn't call glEnable/glDisable with es3 enums unless the
--enable-unsafe-es3-apis flag is set.

[bajones, 2015-03-11 00:29:09]

On 2015/03/10 at 22:54:46, piman wrote:
> We shouldn't call glEnable/glDisable with es3 enums unless the
--enable-unsafe-es3-apis flag is set.

Good catch. Fixed.

[piman, 2015-03-11 00:43:40]

LGTM+nits

https://codereview.chromium.org/1000483002/diff/40001/gpu/command_buffer/serv...
File gpu/command_buffer/service/context_state_impl_autogen.h (right):

https://codereview.chromium.org/1000483002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state_impl_autogen.h:168: if
(feature_info_->IsES3Capable() &&
nit: maybe test this only once for both enables?

https://codereview.chromium.org/1000483002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state_impl_autogen.h:170:
enable_flags.cached_primitive_restart_fixed_index)
nit: needs brackets per style guide because body is >1 line.

https://codereview.chromium.org/1000483002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state_impl_autogen.h:190: if
(feature_info_->IsES3Capable())
nit: same here, test only once for both enables

https://codereview.chromium.org/1000483002/diff/40001/gpu/command_buffer/serv...
gpu/command_buffer/service/context_state_impl_autogen.h:191:
EnableDisable(GL_PRIMITIVE_RESTART_FIXED_INDEX,
nit: same here wrt brackets.

[bajones, 2015-03-11 20:18:25]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-03-11 20:18:25]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1000483002/#ps60001
(title: "Addressed piman@'s new feedback")

[commit-bot: I haz the power, 2015-03-11 20:19:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000483002/60001

[commit-bot: I haz the power, 2015-03-11 20:22:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 20:22:55]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[bajones, 2015-03-11 20:39:09]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-03-11 20:39:09]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1000483002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-11 20:39:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000483002/80001

[commit-bot: I haz the power, 2015-03-12 00:45:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-12 00:45:46]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bajones, 2015-03-12 20:23:28]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-03-12 20:23:28]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1000483002/#ps120001
(title: "Fixed test expectations")

[commit-bot: I haz the power, 2015-03-12 20:23:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000483002/120001

[commit-bot: I haz the power, 2015-03-12 20:29:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-12 20:29:04]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[bajones, 2015-03-12 20:33:56]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-03-12 20:33:57]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1000483002/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2015-03-12 20:35:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000483002/140001

[bajones, 2015-03-12 22:49:14]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-03-12 22:49:15]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1000483002/#ps160001
(title: "Rebase against zmo@'s revert of a different CL which was causing
issues")

[commit-bot: I haz the power, 2015-03-12 22:49:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000483002/160001

[commit-bot: I haz the power, 2015-03-13 02:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-13 02:21:11]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bajones, 2015-03-18 23:00:00]

The CQ bit was checked by bajones@chromium.org

[bajones, 2015-03-18 23:00:00]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1000483002/#ps180001
(title: "Removed PRIMITIVE_RESTART_FIXED_INDEX, since that's apparently only in
desktop GL 4.3+")

[commit-bot: I haz the power, 2015-03-18 23:00:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1000483002/180001

[commit-bot: I haz the power, 2015-03-19 01:35:59]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-03-19 01:36:49]

Patchset 10 (id:??) landed as
https://crrev.com/54ecef179cb661240c978dded621a910ea2bda1c
Cr-Commit-Position: refs/heads/master@{#321263}