chromecast/browser/metrics/cast_metrics_service_client.cc - Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/metrics/cast_metrics_service_client.cc

Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, don't include useless switches Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_metrics_service_client.cc ('K') | « chromecast/browser/metrics/cast_metrics_service_client.h ('k') | components/crash/app/breakpad_mac.mm » ('j') | components/metrics/metrics_service_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/metrics/cast_metrics_service_client.cc

diff --git a/chromecast/browser/metrics/cast_metrics_service_client.cc b/chromecast/browser/metrics/cast_metrics_service_client.cc

index 48bf45bbfd2e70210c2a7f9bf800ee86e59fba9f..59d3bbecb39799b703d1d5c04891f5c66fbd4946 100644

--- a/chromecast/browser/metrics/cast_metrics_service_client.cc

+++ b/chromecast/browser/metrics/cast_metrics_service_client.cc

@@ -52,6 +52,9 @@ void CastMetricsServiceClient::SetMetricsClientId(

PlatformSetClientID(cast_service_, client_id);

}

+void CastMetricsServiceClient::RecordingDisabled() {

void CastMetricsServiceClient::StoreClientInfo(

const ::metrics::ClientInfo& client_info) {

const std::string& client_id = client_info.client_id;