components/metrics/metrics_service_client.h - Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/metrics/metrics_service_client.h

Issue 1000203007: Set a "metrics_client_id" crash key instead of "guid" on Mac OS X (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase, don't include useless switches Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/metrics/chrome_metrics_service_client.cc ('K') | « components/metrics/metrics_service.cc ('k') | components/metrics/test_metrics_service_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/metrics/metrics_service_client.h

diff --git a/components/metrics/metrics_service_client.h b/components/metrics/metrics_service_client.h

index 1b481f998830ad4fdf746adfde3213e8e0107ccd..d33ad8539900baca1694446c7db49434a50d8cf0 100644

--- a/components/metrics/metrics_service_client.h

+++ b/components/metrics/metrics_service_client.h

@@ -29,6 +29,10 @@ class MetricsServiceClient {

// when metrics recording gets enabled.

virtual void SetMetricsClientId(const std::string& client_id) = 0;

+ // Notifies the client that recording is disabled, so that other services

+ // (such as crash reporting) can clear any association with metrics.

+ virtual void RecordingDisabled() = 0;

Ilya Sherman 2015/03/24 00:22:23 nit: Let's name this "OnRecordingDisabled", to emp

// Whether there's an "off the record" (aka "Incognito") session active.

virtual bool IsOffTheRecordSessionActive() = 0;